From 1b92ee2f5a221bc760a499fbadd53c95acec54db Mon Sep 17 00:00:00 2001
From: Ludovic Hussonnois <ludovic.hussonnois@c-s.fr>
Date: Mon, 10 Apr 2017 11:16:54 +0100
Subject: [PATCH] BUG: Correct superclass call for DoInit and DoUpdate.

---
 .../AppClassification/app/otbTrainVectorClassifier.cxx      | 6 +++---
 .../AppClassification/include/otbTrainVectorBase.txx        | 6 +-----
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/Modules/Applications/AppClassification/app/otbTrainVectorClassifier.cxx b/Modules/Applications/AppClassification/app/otbTrainVectorClassifier.cxx
index 935de9401c..55ae73e91c 100644
--- a/Modules/Applications/AppClassification/app/otbTrainVectorClassifier.cxx
+++ b/Modules/Applications/AppClassification/app/otbTrainVectorClassifier.cxx
@@ -52,12 +52,12 @@ public:
 protected:
   void DoInit()
   {
-    TrainVectorBase::DoInit();
+    Superclass::DoInit();
   }
 
   void DoUpdateParameters()
   {
-    TrainVectorBase::DoUpdateParameters();
+    Superclass::DoUpdateParameters();
   }
 
   void DoExecute()
@@ -73,7 +73,7 @@ protected:
         }
       }
 
-      TrainVectorBase::DoExecute();
+      Superclass::DoExecute();
 
       if (GetClassifierCategory() == Supervised)
         {
diff --git a/Modules/Applications/AppClassification/include/otbTrainVectorBase.txx b/Modules/Applications/AppClassification/include/otbTrainVectorBase.txx
index 9e91e70fc5..c7fdda03d9 100644
--- a/Modules/Applications/AppClassification/include/otbTrainVectorBase.txx
+++ b/Modules/Applications/AppClassification/include/otbTrainVectorBase.txx
@@ -101,13 +101,11 @@ void TrainVectorBase::DoInit()
   Superclass::DoInit();
 
   AddRANDParameter();
-
-  DoInit();
 }
 
 void TrainVectorBase::DoUpdateParameters()
 {
-  LearningApplicationBase::DoUpdateParameters();
+  Superclass::DoUpdateParameters();
 
   // if vector data is present and updated then reload fields
   if( HasValue( "io.vd" ) )
@@ -141,8 +139,6 @@ void TrainVectorBase::DoUpdateParameters()
         }
       }
     }
-
-  DoUpdateParameters();
 }
 
 void TrainVectorBase::DoExecute()
-- 
GitLab