From 045ec613291c5c8fb8d281dbc12ad2f5aaa14687 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ga=C3=ABlle=20USSEGLIO?= <gaelle.usseglio@cnes.fr>
Date: Thu, 17 Oct 2019 08:35:20 +0000
Subject: [PATCH] WRG : Warning fixes

---
 app/otbSARCorrelationGrid.cxx                        | 5 -----
 include/otbSARDopplerCentroidFreqImageFilter.txx     | 2 +-
 include/otbSARTemporalCorrelationGridImageFilter.txx | 1 -
 include/otbSARUpdateMetadataImageFilter.txx          | 2 +-
 include/otbTilesAnalysisImageFilter.h                | 2 +-
 5 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/app/otbSARCorrelationGrid.cxx b/app/otbSARCorrelationGrid.cxx
index 7976294..9f85c79 100644
--- a/app/otbSARCorrelationGrid.cxx
+++ b/app/otbSARCorrelationGrid.cxx
@@ -151,11 +151,6 @@ void DoExecute() override
   minMaxFilter->SetImage(correlationFilter->GetOutput());
   minMaxFilter->ComputeMaximum();
 
-  float shiftSLC_range = ((correlationFilter->GetOutput()->GetLargestPossibleRegion().GetSize()[0]/2.)-
-		       minMaxFilter->GetIndexOfMaximum()[0]) * static_cast<float>(factorML_ran);
-  float shiftSLC_azimut = ((correlationFilter->GetOutput()->GetLargestPossibleRegion().GetSize()[1]/2.)
-			-minMaxFilter->GetIndexOfMaximum()[1]) * static_cast<float>(factorML_azi);
-
   float shiftML_range = ((correlationFilter->GetOutput()->GetLargestPossibleRegion().GetSize()[0]/2.)-
 			  minMaxFilter->GetIndexOfMaximum()[0]);
   float shiftML_azimut = ((correlationFilter->GetOutput()->GetLargestPossibleRegion().GetSize()[1]/2.)
diff --git a/include/otbSARDopplerCentroidFreqImageFilter.txx b/include/otbSARDopplerCentroidFreqImageFilter.txx
index f2bab74..9a216cc 100644
--- a/include/otbSARDopplerCentroidFreqImageFilter.txx
+++ b/include/otbSARDopplerCentroidFreqImageFilter.txx
@@ -205,7 +205,7 @@ namespace otb
     
     this->getAllCoefs(inputKWL, DCFRecords);
 
-    DurationType diffAziTimeMin;
+    DurationType diffAziTimeMin(0);
     unsigned int polySelected = 0;
     
     // Select one polynomial (with m_MidAziTime)
diff --git a/include/otbSARTemporalCorrelationGridImageFilter.txx b/include/otbSARTemporalCorrelationGridImageFilter.txx
index a7ec555..8f8fe2c 100644
--- a/include/otbSARTemporalCorrelationGridImageFilter.txx
+++ b/include/otbSARTemporalCorrelationGridImageFilter.txx
@@ -478,7 +478,6 @@ namespace otb
     // Typedef for iterators
     typedef itk::ImageScanlineIterator< ImageOutType > OutputIterator;
     typedef itk::ImageRegionConstIterator<ImageInType> MasterSlaveIt;
-    typedef itk::ImageRegionIterator<ImageInType> ExtractIt;
     
     // Iterator on output (Grid geometry)
     OutputIterator OutIt(this->GetOutput(), outputRegionForThread);
diff --git a/include/otbSARUpdateMetadataImageFilter.txx b/include/otbSARUpdateMetadataImageFilter.txx
index 13bbffb..e6e0c1b 100644
--- a/include/otbSARUpdateMetadataImageFilter.txx
+++ b/include/otbSARUpdateMetadataImageFilter.txx
@@ -81,7 +81,7 @@ namespace otb
   template<class TImage>
   void
   SARUpdateMetadataImageFilter< TImage >
-  ::ThreadedGenerateData(const ImageRegionType& outputRegionForThread, itk::ThreadIdType threadId)
+  ::ThreadedGenerateData(const ImageRegionType& outputRegionForThread, itk::ThreadIdType /*threadId*/)
   {
     // Get Input and Output ptr
     ImagePointer outputPtr = this->GetOutput();
diff --git a/include/otbTilesAnalysisImageFilter.h b/include/otbTilesAnalysisImageFilter.h
index 544a6ee..980412b 100644
--- a/include/otbTilesAnalysisImageFilter.h
+++ b/include/otbTilesAnalysisImageFilter.h
@@ -188,7 +188,7 @@ protected:
 
   /** startIndex and stopIndex represent the indices of tiles to process in thread threadId and index for the
       first tile */
-  virtual void ThreadedGenerateData(unsigned int startTileId, unsigned int stopTileId, 
+  void ThreadedGenerateData(unsigned int startTileId, unsigned int stopTileId, 
 				    unsigned int firstTileIndexL, unsigned int firstTileIndexC,
 				    itk::ThreadIdType threadId);
 
-- 
GitLab