COMP: Fix Variadic Input Image Filters for g++8.2.0

With recent compilers, these two filters present the following compilation
errors.

    [ 62%] Building CXX object Modules/Applications/AppClassification/app/CMakeFiles/otbapp_ZonalStatistics.dir/otbZonalStatistics.cxx.o
    In file included from src/otb/Modules/Core/Functor/include/otbVariadicNamedInputsImageFilter.h:23,
                     from src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.h:24,
                     from src/otb/Modules/Applications/AppClassification/app/otbZonalStatistics.cxx:41:
    src/otb/Modules/Core/Functor/include/otbVariadicInputsImageFilter.h: In member function ‘auto otb::VariadicInputsImageFilter<TOuptut, TInputs>::GetInputsImpl(std::index_sequence<Is ...>)’:
    src/otb/Modules/Core/Functor/include/otbVariadicInputsImageFilter.h:154:47: error: expected primary-expression before ‘)’ token
         return std::make_tuple(this->GetInput<Is>()...);
                                                   ^
    In file included from src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.h:24,
                     from src/otb/Modules/Applications/AppClassification/app/otbZonalStatistics.cxx:41:
    src/otb/Modules/Core/Functor/include/otbVariadicNamedInputsImageFilter.h: In member function ‘void otb::VariadicNamedInputsImageFilter<TOuptut, TInputNameMap, TInputs>::SetInput(Tag, otb::VariadicNamedInputsImageFilter<TOuptut, TInputNameMap, TInputs>::InputImageType<otb::internal::tuple_index<Tag, TInputNameMap>::value>*)’:
    src/otb/Modules/Core/Functor/include/otbVariadicNamedInputsImageFilter.h:141:17: error: expected primary-expression before ‘>’ token
         SetInput<Tag>(inputPtr);
                     ^
    src/otb/Modules/Core/Functor/include/otbVariadicNamedInputsImageFilter.h: In member function ‘otb::VariadicNamedInputsImageFilter<TOuptut, TInputNameMap, TInputs>::InputImageType<otb::internal::tuple_index<Tag, TInputNameMap>::value>* otb::VariadicNamedInputsImageFilter<TOuptut, TInputNameMap, TInputs>::GetInput(Tag)’:
    src/otb/Modules/Core/Functor/include/otbVariadicNamedInputsImageFilter.h:164:24: error: expected primary-expression before ‘>’ token
         return GetInput<Tag>();
                            ^
    src/otb/Modules/Core/Functor/include/otbVariadicNamedInputsImageFilter.h:164:26: error: expected primary-expression before ‘)’ token
         return GetInput<Tag>();
                              ^
    In file included from src/otb/Modules/Core/Functor/include/otbVariadicNamedInputsImageFilter.h:23,
                     from src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.h:24,
                     from src/otb/Modules/Applications/AppClassification/app/otbZonalStatistics.cxx:41:
    src/otb/Modules/Core/Functor/include/otbVariadicInputsImageFilter.h: In instantiation of ‘auto otb::VariadicInputsImageFilter<TOuptut, TInputs>::GetInputsImpl(std::index_sequence<Is ...>) [with long unsigned int ...Is = {0}; TOuptut = otb::VectorImage<float, 2>; TInputs = {otb::Image<int, 2>}; std::index_sequence<Is ...> = std::integer_sequence<long unsigned int, 0>]’:
    src/otb/Modules/Core/Functor/include/otbVariadicInputsImageFilter.h:133:72:   required from ‘auto otb::VariadicInputsImageFilter<TOuptut, TInputs>::GetInputs() [with TOuptut = otb::VectorImage<float, 2>; TInputs = {otb::Image<int, 2>}]’
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx:298:73:   required from ‘void otb::FunctorImageFilter<TFunction, TNameMap>::GenerateInputRequestedRegion() [with TFunction = otb::Wrapper::ZonalStatistics::EncoderFunctorType<int, itk::VariableLengthVector<float> >; TNameMap = void ’
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx:289:6:   required from here
    src/otb/Modules/Core/Functor/include/otbVariadicInputsImageFilter.h:154:42: error: invalid operands of types ‘<unresolved overloaded function type>’ and ‘long unsigned int’ to binary ‘operator<’
         return std::make_tuple(this->GetInput<Is>()...);
                                ~~~~~~~~~~~~~~^~~
    In file included from src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.h:500,
                     from src/otb/Modules/Applications/AppClassification/app/otbZonalStatistics.cxx:41:
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx: In instantiation of ‘void otb::FunctorImageFilter<TFunction, TNameMap>::GenerateInputRequestedRegion() [with TFunction = otb::Wrapper::ZonalStatistics::EncoderFunctorType<int, itk::VariableLengthVector<float> >; TNameMap = void]’:
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx:289:6:   required from here
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx:298:73: error: invalid use of void expression
       functor_filter_details::SetInputRequestedRegions<InputHasNeighborhood>(this->GetInputs(), requestedRegion, m_Radius);
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx: In instantiation of ‘void otb::FunctorImageFilter<TFunction, TNameMap>::GenerateOutputInformation() [with TFunction = otb::Wrapper::ZonalStatistics::EncoderFunctorType<int, itk::VariableLengthVector<float> >; TNameMap = void]’:
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx:302:6:   required from here
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx:308:8: error: ‘void inputs’ has incomplete type
       auto inputs = this->GetInputs();
            ^~~~~~
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx: In instantiation of ‘void otb::FunctorImageFilter<TFunction, TNameMap>::ThreadedGenerateData(const OutputImageRegionType&, itk::ThreadIdType) [with TFunction = otb::Wrapper::ZonalStatistics::EncoderFunctorType<int, itk::VariableLengthVector<float> >; TNameMap = void; otb::FunctorImageFilter<TFunction, TNameMap>::OutputImageRegionType = itk::ImageRegion<2>; itk::ThreadIdType = unsigned int]’:
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx:321:6:   required from here
    src/otb/Modules/Core/Functor/include/otbFunctorImageFilter.hxx:336:62: error: invalid use of void expression
       auto inputIterators = functor_filter_details::MakeIterators(this->GetInputs(), outputRegionForThread, m_Radius, InputHasNeighborhood{});
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    make[5]: *** [Modules/Applications/AppClassification/app/CMakeFiles/otbapp_ZonalStatistics.dir/otbZonalStatistics.cxx.o] Error 1
    make[4]: *** [Modules/Applications/AppClassification/app/CMakeFiles/otbapp_ZonalStatistics.dir/all] Error 2
26 jobs for !660 with Fix_VariadicNamedImageFilter_with_gcc820 in 59 minutes and 34 seconds (queued for 245 minutes and 48 seconds)
detached
Status Job ID Name Coverage
  Precheck
passed #18228
fast-build

00:05:22

failed #18549
allowed to fail
legal-check

00:01:58

failed #18194
fast-build

failed #18166
fast-build

failed #18191
fast-build

failed #18163
fast-build

failed #18149
fast-build

failed #18190
fast-build

failed #18150
allowed to fail
legal-check

failed #18195
allowed to fail
legal-check

failed #18192
allowed to fail
legal-check

failed #18167
allowed to fail
legal-check

failed #18162
allowed to fail
legal-check

failed #18229
allowed to fail
legal-check

00:03:28

 
  Prepare
passed #18152
centos-xdk-prepare

00:02:24

passed #18333
macos
macos-xdk-prepare

00:02:46

passed #18151
ubuntu-xdk-prepare

00:01:40

passed #18154
windows10
windows-10-prepare

00:01:36

passed #18155
windows8
windows-8-prepare

00:01:41

failed #18153
macos
macos-xdk-prepare

00:00:00

 
  Build
passed #18158
centos-xdk-build

00:30:08

passed #18156
debian-build

00:23:29

passed #18159
macos
macos-xdk-build

00:44:13

passed #18157
ubuntu-xdk-build-doc

00:33:31

passed #18160
windows10
windows-10-build

00:47:00

passed #18161
windows8
windows-8-build

00:44:10

 
Name Stage Failure
failed
legal-check Precheck
$ ./CI/contributors_check.sh

WARNING: ***************************************************************
WARNING: Unknown contributors found:
WARNING: - Luc Hermitte <luc.hermitte@cnes.fr>
WARNING: Check if they have signed the contributor license agreements.
WARNING: ***************************************************************

ERROR: Job failed: exit code 1