WRG: correct clang warnings

Code/BasicFilters/otbBCOInterpolateImageFunction.txx

@@ -137,7 +137,6 @@ BCOInterpolateImageFunction<TInputImage, TCoordRep>
 {
   int radius = this->GetRadius();
   unsigned int winSize = 2*radius+1;
-  double norma;
   unsigned int dim;
 
   IndexType baseIndex;
@@ -207,7 +206,6 @@ BCOInterpolateImageFunction< otb::VectorImage<TPixel, VImageDimension> , TCoordR
 
   int radius = this->GetRadius();
   unsigned int winSize = 2*radius+1;
-  double norma;
   unsigned int dim;
   unsigned int componentNumber = this->GetInputImage()->GetNumberOfComponentsPerPixel();
 

Code/IO/otbMapFileProductWriter.txx

@@ -29,9 +29,12 @@ namespace otb
  */
 template <class TInputImage>
 MapFileProductWriter<TInputImage>
-::MapFileProductWriter(): m_TileSize(256), m_SRID(26918), m_CurrentDepth(0)
+::MapFileProductWriter()
 {
   m_GenericRSResampler = GenericRSResamplerType::New();
+  m_TileSize = 256;
+  m_CurrentDepth = 0;
+  m_SRID = 26918;
 
   // Modify superclass default values, can be overridden by subclasses
   this->SetNumberOfRequiredInputs(1);

Testing/Code/BasicFilters/otbBandMathXImageFilter.cxx

@@ -206,9 +206,7 @@ int otbBandMathXImageFilterConv( int itkNotUsed(argc), char* argv [])
   typedef ImageType::PixelType                      PixelType;
   typedef otb::BandMathXImageFilter<ImageType>      FilterType;
 
-  unsigned int i;
   const unsigned int N = 100, D1=3, D2=1, D3=1;
-  unsigned int FAIL_FLAG = 0;
 
   ImageType::SizeType size;
   size.Fill(N);
@@ -241,7 +239,7 @@ int otbBandMathXImageFilterConv( int itkNotUsed(argc), char* argv [])
   image3->Allocate();
 
   typedef itk::ConstNeighborhoodIterator<ImageType> IteratorType;
-  IteratorType::RadiusType radius,radius2,radius3;
+  IteratorType::RadiusType radius;
   radius[0]=1; // Size x direction
   radius[1]=2; // Size y direction
 
@@ -328,10 +326,6 @@ int otbBandMathXImageFilterConv( int itkNotUsed(argc), char* argv [])
 
   for (it1.GoToBegin(), it2.GoToBegin(), it3.GoToBegin(), itoutput1.GoToBegin(), itoutput2.GoToBegin(); !it1.IsAtEnd(); ++it1, ++it2, ++it3, ++itoutput1, ++itoutput2)
     {
-    ImageType::IndexType i1 = it1.GetIndex();
-    ImageType::IndexType i2 = it2.GetIndex();
-    ImageType::IndexType i3 = it3.GetIndex();
-    
     PixelType px1(output1->GetNumberOfComponentsPerPixel());
     PixelType px2(output2->GetNumberOfComponentsPerPixel());
 
@@ -439,8 +433,7 @@ int otbBandMathXImageFilterTxt( int itkNotUsed(argc), char* argv [])
   const char * outputFilename  = argv[2];
 
   typedef otb::VectorImage<double, 2>              ImageType;
-  typedef ImageType::PixelType                      PixelType;
-  typedef otb::BandMathXImageFilter<ImageType>      FilterType;
+  typedef otb::BandMathXImageFilter<ImageType>     FilterType;
 
   FilterType::Pointer         filter       = FilterType::New();
 
@@ -457,8 +450,7 @@ int otbBandMathXImageFilterWithIdx( int itkNotUsed(argc), char* argv[])
   const char * outfname2       = argv[2];
 
   
-  typedef otb::VectorImage<double, 2>                          ImageType;
-  typedef ImageType::PixelType                            PixelType;
+  typedef otb::VectorImage<double, 2>                     ImageType;
   typedef otb::BandMathXImageFilter<ImageType>            FilterType;
   typedef otb::ImageFileWriter<ImageType>                 WriterType;
 

Testing/Code/Radiometry/otbAtmosphericCorrectionSequencement.cxx

@@ -139,13 +139,10 @@ int otbAtmosphericCorrectionSequencementTest(int argc, char *argv[])
 
   typedef otb::AtmosphericRadiativeTerms                                    AtmosphericRadiativeTermsType;
   typedef AtmosphericRadiativeTermsType::Pointer                  AtmosphericRadiativeTermsPointerType;
-  typedef otb::AtmosphericRadiativeTerms::DataVectorType DataVectorType;
 
   typedef otb::FilterFunctionValues                                         FilterFunctionValuesType;
-  typedef FilterFunctionValuesType::WavelengthSpectralBandType              ValueType;                //float
   typedef FilterFunctionValuesType::ValuesVectorType                        ValuesVectorType;         //std::vector<float>
 
-  typedef AcquiCorrectionParametersType::WavelengthSpectralBandVectorType        WavelengthSpectralBandVectorType;
 
   AcquiCorrectionParametersPointerType paramAcqui = AcquiCorrectionParametersType::New();
   AtmoCorrectionParametersPointerType  paramAtmo = AtmoCorrectionParametersType::New();

Testing/Code/Radiometry/otbRomaniaReflectanceToRomaniaSurfaceReflectanceImageFilter.cxx

@@ -43,12 +43,6 @@ int otbRomaniaReflectanceToRomaniaSurfaceReflectanceImageFilter(int itkNotUsed(a
   
   typedef otb::RadiometryCorrectionParametersToAtmosphericRadiativeTerms
   CorrectionParametersToRadiativeTermsType;
-  /*typedef otb::AtmosphericCorrectionParameters                 CorrectionParametersType; chris
-  typedef otb::AtmosphericRadiativeTerms                       RadiativeTermsType;
-  typedef otb::FilterFunctionValues                            FilterFunctionValuesType;
-  typedef CorrectionParametersType::AerosolModelType           AerosolModelType;
-  typedef FilterFunctionValuesType::WavelengthSpectralBandType ValueType;
-  typedef FilterFunctionValuesType::ValuesVectorType           ValuesVectorType; */
 
   typedef otb::AtmosphericCorrectionParameters                              AtmoCorrectionParametersType;
   typedef AtmoCorrectionParametersType::Pointer                    AtmoCorrectionParametersPointerType;
@@ -65,13 +59,6 @@ int otbRomaniaReflectanceToRomaniaSurfaceReflectanceImageFilter(int itkNotUsed(a
   typedef FilterFunctionValuesType::WavelengthSpectralBandType          ValueType;                //float
   typedef FilterFunctionValuesType::ValuesVectorType                    ValuesVectorType;         //std::vector<float>
 
-  typedef AcquiCorrectionParametersType::WavelengthSpectralBandVectorType        WavelengthSpectralBandVectorType;
-
-
-
-  //AtmosphericRadiativeTermsType::Pointer                         radiative     = AtmosphericRadiativeTermsType::New(); chris
-  //CorrectionParametersType::Pointer                   param         = CorrectionParametersType::New(); chris
-  //CorrectionParametersToRadiativeTermsType*           corrToRadia   = new CorrectionParametersToRadiativeTermsType; chris
   AcquiCorrectionParametersPointerType paramAcqui = AcquiCorrectionParametersType::New();
   AtmoCorrectionParametersPointerType  paramAtmo = AtmoCorrectionParametersType::New();
   FilterFunctionValuesType::Pointer                   functionValues;

Testing/Code/Radiometry/otbSurfaceAdjacencyEffectCorrectionSchemeFilter.cxx

@@ -61,9 +61,6 @@ int otbSurfaceAdjacencyEffectCorrectionSchemeFilter(int itkNotUsed(argc), char *
   typedef FilterFunctionValuesType::WavelengthSpectralBandType          ValueType;                //float
   typedef FilterFunctionValuesType::ValuesVectorType                    ValuesVectorType;         //std::vector<float>
 
-  typedef AcquiCorrectionParametersType::WavelengthSpectralBandVectorType        WavelengthSpectralBandVectorType;
-
-
   AcquiCorrectionParametersPointerType paramAcqui = AcquiCorrectionParametersType::New();
   AtmoCorrectionParametersPointerType  paramAtmo = AtmoCorrectionParametersType::New();
   FilterFunctionValuesType::Pointer                   functionValues;