Merge branch '2040-RPC_model' of gitlab.orfeo-toolbox.org:orfeotoolbox/otb into 2040-RPC_model

Data/Baseline/OTB/Files/otbGCPsToRPCSensorModelImageFilterWithoutDEMOutput.txt

-{"LineOffset": "2224.5", "SampleOffset": "2224.5", "LatOffset": "43.6089", "LonOffset": "1.42524", "HeightOffset": "0", "LineScale": "225.5", "SampleScale": "225.5", "LatScale": "1", "LonScale": "1", "HeightScale": "1", "LineNum": [ "0.00174891",  "0.469879",  "-182.989",  "-4.38776e-15",  "0.000183514",  "3.26103e-23",  "1.88011e-36",  "-0.000133312",  "-0.00295522",  "0",  "0",  "4.13724e-05",  "-2.66117e-05",  "0",  "-0.0037833",  "-0.00397229",  "0",  "0",  "0",  "0", ], "LineDen": [ "1",  "0.119555",  "-0.788492",  "0",  "-0.00176245",  "0",  "0",  "-0.69207",  "-0.725175",  "0",  "0",  "4.36024e-06",  "-1.21576e-05",  "0",  "-1.60709e-05",  "-1.09766e-05",  "0",  "0",  "0",  "0", ], "SampleNum": [ "-4.02927e-05",  "140.123",  "0.720552",  "-6.37125e-15",  "-0.000306972",  "3.63979e-25",  "7.44761e-39",  "7.06041e-05",  "0.000393491",  "0",  "0",  "0.0051405",  "0.00169872",  "0",  "3.04758e-06",  "3.05976e-05",  "0",  "0",  "0",  "0", ], "SampleDen": [ "1",  "-0.0140619",  "0.0561058",  "0",  "-0.00165426",  "0",  "0",  "-0.720302",  "-0.238048",  "0",  "0",  "-2.11371e-07",  "-2.52599e-06",  "0",  "1.28711e-06",  "7.08205e-06",  "0",  "0",  "0",  "0", ], }
-Residual ground error: 0.1243213845
+{"LineOffset": "2224.5", "SampleOffset": "2224.5", "LatOffset": "43.6089", "LonOffset": "1.42524", "HeightOffset": "0", "LineScale": "225.5", "SampleScale": "225.5", "LatScale": "1", "LonScale": "1", "HeightScale": "1", "LineNum": [ "0.00176507",  "0.469826",  "-182.989",  "-3.97557e-14",  "0.000167599",  "-4.11403e-23",  "4.64211e-36",  "-0.000132256",  "-0.00299522",  "0",  "0",  "4.13719e-05",  "-2.66116e-05",  "0",  "-0.00378323",  "-0.0039722",  "0",  "0",  "0",  "0", ], "LineDen": [ "1",  "0.116648",  "-0.795797",  "0",  "-0.0017625",  "0",  "0",  "-0.692057",  "-0.725159",  "0",  "0",  "4.24205e-06",  "-1.2217e-05",  "0",  "-1.62292e-05",  "-1.11751e-05",  "0",  "0",  "0",  "0", ], "SampleNum": [ "-4.03023e-05",  "140.123",  "0.720549",  "-3.96237e-14",  "-0.000307018",  "-6.10744e-25",  "3.08505e-39",  "7.06292e-05",  "0.000393857",  "0",  "0",  "0.00514045",  "0.00169871",  "0",  "3.04772e-06",  "3.05975e-05",  "0",  "0",  "0",  "0", ], "SampleDen": [ "1",  "-0.0140652",  "0.0561119",  "0",  "-0.00165428",  "0",  "0",  "-0.720295",  "-0.238046",  "0",  "0",  "-2.11567e-07",  "-2.527e-06",  "0",  "1.28729e-06",  "7.08213e-06",  "0",  "0",  "0",  "0", ], }
+Residual ground error: 1.2432282311

Modules/Filtering/Projection/src/otbRPCSolver.cxx

@@ -184,7 +184,7 @@ void computeCoefficients(const std::vector<PrecisionType> & f,
     // compute the residual
     auto residual = M.transpose()*w2*(M*coeffs-r);
 
-    auto residualValue = inner_product(residual,residual);
+    res = inner_product(residual,residual);
   }
 
   outCoeffs.assign(coeffs.begin(), coeffs.end());
@@ -266,7 +266,7 @@ void RPCSolver::Solve(const GCPsContainerType& gcpContainer, PrecisionType& rmsE
   {
     const auto & imagePoint = gcp.first;
 
-    minc = std::min(imagePoint[0], minl);
+    minc = std::min(imagePoint[0], minc);
     maxc = std::max(imagePoint[0], maxc);
 
     minl = std::min(imagePoint[1], minl);
@@ -385,7 +385,7 @@ void RPCSolver::Solve(const GCPsContainerType& gcpContainer, PrecisionType& rmsE
                 + (gcp.first[1] - outPoint[1]) * (gcp.first[1] - outPoint[1]);
   }
 
-  rmsError = std::sqrt(rmseAcc)/numberOfPoints;
+  rmsError = std::sqrt(rmseAcc/numberOfPoints);
 }
 
 }
\ No newline at end of file