From 40e7f2a400de2eca5ce1c75022c7cf0cf76c57ae Mon Sep 17 00:00:00 2001
From: Julien Michel <julien.michel@cnes.fr>
Date: Tue, 6 Mar 2018 17:19:57 +0100
Subject: [PATCH] WRG: Fix a bunch of clang warnings, mostly missing override
---
.../AppClassification/app/otbTrainImagesClassifier.cxx | 2 +-
Modules/Core/ObjectList/include/otbImageList.h | 2 +-
.../MPI/MPITiffWriter/include/otbSimpleParallelTiffWriter.h | 4 ++--
.../OssimPlugins/include/ossim/ossimSarSensorModel.h | 4 ++--
.../ApplicationEngine/include/otbWrapperParameterList.h | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/Modules/Applications/AppClassification/app/otbTrainImagesClassifier.cxx b/Modules/Applications/AppClassification/app/otbTrainImagesClassifier.cxx
index a76f81dce7..f26b4b32d4 100644
--- a/Modules/Applications/AppClassification/app/otbTrainImagesClassifier.cxx
+++ b/Modules/Applications/AppClassification/app/otbTrainImagesClassifier.cxx
@@ -157,7 +157,7 @@ public:
}
- void DoExecute()
+ void DoExecute() ITK_OVERRIDE
{
TrainFileNamesHandler fileNames;
std::vector<std::string> vectorFileList;
diff --git a/Modules/Core/ObjectList/include/otbImageList.h b/Modules/Core/ObjectList/include/otbImageList.h
index 4cb77bddec..fc836cb047 100644
--- a/Modules/Core/ObjectList/include/otbImageList.h
+++ b/Modules/Core/ObjectList/include/otbImageList.h
@@ -68,7 +68,7 @@ public:
throw (itk::InvalidRequestedRegionError) ITK_OVERRIDE;
void UpdateOutputData(void) ITK_OVERRIDE;
- void SetRequestedRegion(const itk::DataObject * source);
+ void SetRequestedRegion(const itk::DataObject * source) ITK_OVERRIDE;
protected:
/** Constructor */
diff --git a/Modules/MPI/MPITiffWriter/include/otbSimpleParallelTiffWriter.h b/Modules/MPI/MPITiffWriter/include/otbSimpleParallelTiffWriter.h
index c404d25d50..64e574384a 100644
--- a/Modules/MPI/MPITiffWriter/include/otbSimpleParallelTiffWriter.h
+++ b/Modules/MPI/MPITiffWriter/include/otbSimpleParallelTiffWriter.h
@@ -214,7 +214,7 @@ public:
const InputImageType* GetInput();
/** Does the real work. */
- virtual void Update();
+ virtual void Update() ITK_OVERRIDE;
/** SimpleParallelTiffWriter Methods */
virtual void SetFileName(const char* extendedFileName);
@@ -255,7 +255,7 @@ public:
protected:
SimpleParallelTiffWriter();
virtual ~SimpleParallelTiffWriter();
- void PrintSelf(std::ostream& os, itk::Indent indent) const;
+ void PrintSelf(std::ostream& os, itk::Indent indent) const ITK_OVERRIDE;
private:
SimpleParallelTiffWriter(const SimpleParallelTiffWriter &); //purposely not implemented
diff --git a/Modules/ThirdParty/OssimPlugins/include/ossim/ossimSarSensorModel.h b/Modules/ThirdParty/OssimPlugins/include/ossim/ossimSarSensorModel.h
index 542b29e6f8..c1d0cb7761 100644
--- a/Modules/ThirdParty/OssimPlugins/include/ossim/ossimSarSensorModel.h
+++ b/Modules/ThirdParty/OssimPlugins/include/ossim/ossimSarSensorModel.h
@@ -276,7 +276,7 @@ public:
bool autovalidateForwardModelFromGCPs(double resTol = 25);
//Pure virtual in base class
- bool useForward() const;
+ bool useForward() const override;
void optimizeTimeOffsetsFromGcps();
@@ -336,7 +336,7 @@ public:
virtual std::ostream& print(std::ostream& out) const override;
protected:
- TYPE_DATA;
+ TYPE_DATA
/**
* Compute range and doppler frequency from an input point, sensor
diff --git a/Modules/Wrappers/ApplicationEngine/include/otbWrapperParameterList.h b/Modules/Wrappers/ApplicationEngine/include/otbWrapperParameterList.h
index 2c9c699fbe..e54590e42f 100644
--- a/Modules/Wrappers/ApplicationEngine/include/otbWrapperParameterList.h
+++ b/Modules/Wrappers/ApplicationEngine/include/otbWrapperParameterList.h
@@ -91,7 +91,7 @@ public:
void SetNthFileName( std::size_t, const std::string & ) override;
/** */
- std::size_t SetStrings( const StringVector & );
+ std::size_t SetStrings( const StringVector & ) override;
/** */
std::size_t GetStrings( StringVector & ) const override;
--
GitLab