REFAC: remove not needed c_str found with clang-tidy

Modules/Applications/AppClassification/app/otbComputeImagesStatistics.cxx

@@ -135,7 +135,7 @@ private:
       StreamingStatisticsVImageFilterType::Pointer statsEstimator = StreamingStatisticsVImageFilterType::New();
       std::ostringstream processName;
       processName << "Processing Image (" << imageId+1 << "/" << imageList->Size() << ")";
-      AddProcess(statsEstimator->GetStreamer(), processName.str().c_str());
+      AddProcess(statsEstimator->GetStreamer(), processName.str());
       statsEstimator->SetInput(image);
       statsEstimator->GetStreamer()->SetAutomaticAdaptativeStreaming(GetParameterInt("ram"));
 

Modules/Applications/AppClassification/app/otbDSFuzzyModelEstimation.cxx

@@ -212,7 +212,7 @@ private:
     if (IsParameterEnabled("initmod"))
       {
       std::string descModFile = GetParameterString("initmod");
-      descMod = FuzzyDescriptorsModelManager::Read(descModFile.c_str());
+      descMod = FuzzyDescriptorsModelManager::Read(descModFile);
       descList = FuzzyDescriptorsModelManager::GetDescriptorList(descMod);
       }
     else

Modules/Applications/AppClassification/app/otbVectorDataDSValidation.cxx

@@ -125,7 +125,7 @@ private:
 
     // Load the descriptors model
     std::string descModFile = GetParameterString("descmod");
-    DescriptorsModelType descMod = FuzzyDescriptorsModelManager::Read(descModFile.c_str());
+    DescriptorsModelType descMod = FuzzyDescriptorsModelManager::Read(descModFile);
 
     LabelSetType Bhyp, Phyp;
     int nbSet;

Modules/Applications/AppSegmentation/app/otbLSMSVectorization.cxx

@@ -282,7 +282,7 @@ private:
     std::ostringstream sqloss;
     sqloss.str("");
     sqloss<<"SELECT * FROM \""<<layername<<"\" ORDER BY label";
-    otb::ogr::Layer layerTmp=ogrDS->ExecuteSQL(sqloss.str().c_str(), nullptr, nullptr);
+    otb::ogr::Layer layerTmp=ogrDS->ExecuteSQL(sqloss.str(), nullptr, nullptr);
     otb::ogr::Feature firstFeature = layerTmp.ogr().GetNextFeature();
 
     //Geometry fusion

Modules/IO/IOONERA/src/otbONERAImageIO.cxx

@@ -539,7 +539,7 @@ void ONERAImageIO::InternalWriteImageInformation()
       }
 
     /*-------- This part deals with writing header information ------ */
-    const std::string DataFileName = System::GetRootName(m_FileName.c_str()) + ".dat";
+    const std::string DataFileName = System::GetRootName(m_FileName) + ".dat";
 
     m_Headerfile << "#                    [fichier en-tete produit par les routines de otb (Orfeo ToolBox) ]" <<
     std::endl;

Modules/IO/TestKernel/src/otbTestHelper.cxx

@@ -1678,7 +1678,7 @@ std::map<std::string, int> TestHelper::RegressionTestBaselines(char *baselineFil
 
   std::string myPath = itksys::SystemTools::GetFilenamePath(baselineFilename);
   itksys::Directory myDir;
-  myDir.Load(myPath.c_str());
+  myDir.Load(myPath);
   const unsigned int nbFiles = myDir.GetNumberOfFiles();
 
   const std::string originalBaseline = itksys::SystemTools::GetFilenameWithoutLastExtension(baselineFilename);

Modules/Wrappers/ApplicationEngine/src/otbWrapperDocExampleStructure.cxx

@@ -148,7 +148,7 @@ DocExampleStructure::GenerateCLExample( unsigned int exId )
   // Suppress last added space
   res.erase( res.size()-1, 1);
 
-  return res.c_str();
+  return res;
 }
 
 std::string

Modules/Wrappers/QGIS/src/otbQgisDescriptor.cxx

@@ -46,7 +46,7 @@ int main(int argc, char* argv[])
 #endif
 
   ApplicationRegistry::AddApplicationPath(argv[2]);
-  Application::Pointer appli =  ApplicationRegistry::CreateApplicationFaster(module.c_str());
+  Application::Pointer appli =  ApplicationRegistry::CreateApplicationFaster(module);
   
   assert(!appli.IsNull());