Merge branch '1706-otb-does-not-compile-with-gcc-8-1' into 'develop'

Resolve "OTB does not compile with GCC 8.1"

Closes #1706

See merge request orfeotoolbox/otb!216

Examples/Filtering/CompositeFilterExample.cxx

@@ -287,7 +287,7 @@ int main(int argc, char* argv[])
     {
     writer->Update();
     }
-  catch (itk::ExceptionObject e)
+  catch ( itk::ExceptionObject & e )
     {
     std::cerr << "Error: " << e << std::endl;
     }

Modules/Filtering/Path/test/otbImageToEdgePathFilter.cxx

@@ -30,7 +30,7 @@ int otbImageToEdgePathFilter(int itkNotUsed(argc), char * argv[])
 {
   const char *       inputFilename  = argv[1];
   const char *       outputFilename = argv[2];
-  const unsigned int foreground((const unsigned int) ::atoi(argv[3]));
+  const unsigned int foreground = atoi(argv[3]);
 
   const unsigned int Dimension = 2;
   typedef unsigned char                    PixelType;

Modules/IO/Carto/src/otbCoordinateToName.cxx

@@ -119,7 +119,7 @@ void CoordinateToName::DoEvaluate()
       m_Curl->RetrieveUrlInMemory(urlStream.str(), m_CurlOutput);
       m_IsValid = true;
       }
-    catch(itk::ExceptionObject)
+    catch( itk::ExceptionObject & )
       {
       m_IsValid = false;
       }

Modules/IO/Carto/src/otbPlaceNameToLonLat.cxx

@@ -107,7 +107,7 @@ void PlaceNameToLonLat::RetrieveXML(const std::ostringstream& urlStream)
     m_RequestSucceed = true;
     m_Curl->RetrieveUrlInMemory(urlStream.str(), m_CurlOutput);
     }
-  catch(itk::ExceptionObject)
+  catch( itk::ExceptionObject & )
     {
     m_RequestSucceed = false;
     }

Modules/IO/Carto/test/otbImageToOSMVectorDataGenerator.cxx

@@ -57,7 +57,7 @@ int otbImageToOSMVectorDataGenerator(int argc, char * argv[])
     {
     parser->ParseCommandLine(argc, argv, parseResult);
     }
-  catch ( itk::ExceptionObject )
+  catch ( itk::ExceptionObject & )
     {
     return EXIT_FAILURE;
     }

Modules/IO/Carto/test/otbOSMDataToVectorDataTests.cxx

@@ -65,7 +65,7 @@ int otbOSMToVectorDataGeneratorByName (int argc, char * argv[])
     {
     parser->ParseCommandLine(argc, argv, parseResult);
     }
-  catch ( itk::ExceptionObject )
+  catch ( itk::ExceptionObject & )
     {
     return EXIT_FAILURE;
     }

Modules/Learning/DempsterShafer/include/otbStandardDSCostFunction.hxx

@@ -80,7 +80,7 @@ typename StandardDSCostFunction<TDSValidationFilter>
     {
     internalFunctionGT->SetDescriptorModels(descModel);
     }
-  catch (itk::ExceptionObject /*& err*/)
+  catch ( itk::ExceptionObject & )
     {
     return 1;
     }

Modules/Learning/LearningBase/include/otbSEMClassifier.h

@@ -125,11 +125,11 @@ public:
    * vector should be same as the number of component (or classes).
    * Choose between SetInitialProportions, SetClassLabels or
    * SetNumberOfComponents */
-  void SetInitialProportions(ProportionVectorType& propotion);
-  ProportionVectorType* GetInitialProportions();
+  void SetInitialProportions(ProportionVectorType& proportions);
+  itkGetConstReferenceMacro(InitialProportions,ProportionVectorType);	
 
   /** Gets the result proportion values */
-  ProportionVectorType* GetProportions();
+  itkGetConstReferenceMacro(Proportions,ProportionVectorType);	
 
   /** Set/Gets the initial segmentation. the size of the vector should be
    * the same as the number of samples (length of MeasurementVector) */

Modules/Learning/LearningBase/include/otbSEMClassifier.hxx

@@ -99,14 +99,6 @@ SEMClassifier<TInputImage, TOutputImage>
   m_ExternalLabels = 0;
 }
 
-template<class TInputImage, class TOutputImage>
-typename SEMClassifier<TInputImage, TOutputImage>::ProportionVectorType*
-SEMClassifier<TInputImage, TOutputImage>
-::GetInitialProportions()
-{
-  return m_InitialProportions;
-}
-
 template<class TInputImage, class TOutputImage>
 void
 SEMClassifier<TInputImage, TOutputImage>
@@ -228,14 +220,6 @@ SEMClassifier<TInputImage, TOutputImage>
   return m_ClassLabels;
 }
 
-template<class TInputImage, class TOutputImage>
-typename SEMClassifier<TInputImage, TOutputImage>::ProportionVectorType*
-SEMClassifier<TInputImage, TOutputImage>
-::GetProportions()
-{
-  return &m_Proportions;
-}
-
 template<class TInputImage, class TOutputImage>
 void
 SEMClassifier<TInputImage, TOutputImage>

Modules/Learning/Supervised/test/otbConfusionMatrixCalculatorTest.cxx

@@ -124,7 +124,7 @@ int otbConfusionMatrixCalculatorWrongSize(int argc, char* argv[])
     {
     calculator->Compute();
     }
-  catch (itk::ExceptionObject)
+  catch ( itk::ExceptionObject & )
     {
     return EXIT_FAILURE;
     }

Modules/Radiometry/OpticalCalibration/test/otbAeronetExtractDataBadData.cxx

@@ -38,7 +38,7 @@ int otbAeronetExtractDataBadData(int itkNotUsed(argc), char * argv[])
     {
     reader->Update();
     }
-  catch (itk::ExceptionObject e)
+  catch ( itk::ExceptionObject & )
     {
     return EXIT_SUCCESS;
     }