1. 21 Dec, 2018 1 commit
  2. 18 Jul, 2018 1 commit
    • Victor Poughon's avatar
      REFAC: remove unnecessary calls to c_str · ee124eea
      Victor Poughon authored
      This was done with this script:
      
          #!/bin/bash
      
          set -eou pipefail
      
          # Use C++11 sstream constructor from string
          # Exclude 'ThirdParty' because it uses ossimFilename type
          find Modules/ Examples/ -not -iwholename "*ThirdParty*" -type f -print0 | xargs -0 sed -i -E "s/std::ifstream (.*)\((.*)\.c_str\(\)/std::ifstream \1\(\2/"
          find Modules/ Examples/ -not -iwholename "*ThirdParty*" -type f -print0 | xargs -0 sed -i -E "s/std::ofstream (.*)\((.*)\.c_str\(\)/std::ofstream \1\(\2/"
      
          # Use C++11 ::open(const std::string&) of ifstream, ofstream, etc.
          # Exclude ThirdParty because of ossimFilename type
          find Modules/ Examples/ -not -iwholename "*ThirdParty*" -type f -print0 | xargs -0 sed -i -E "s/\.open\((.*).c_str\(\)/\.open\(\1/"
      
          # No need for c_str when outputing to std::cout and such
          find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/\.c_str\(\) ?<</ <</"
      
          # Use itk::ExceptionObject::SetDescription and SetLocation string versions
          find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/e\.SetDescription\((.*)\.c_str\(\)\)/e\.SetDescription\(\1\)/"
          find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/e\.SetLocation\((.*)\.c_str\(\)\)/e\.SetLocation\(\1\)/"
      
          # Use itksys::SystemTool:: string versions
          find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/itksys::SystemTools::(.*)\((.*)\.c_str\(\)/itksys::SystemTools::\1\(\2/"
          # Exclude otbLogger because it uses GetCurrentDateTime which does not have a string version
          git checkout --  Modules/Core/Common/src/otbLogger.cxx
          # Exclude test/otbOGRLayerStreamStitchingFilter.cxx because there's a double use which is not compatible with the regex
          git checkout -- Modules/Segmentation/OGRProcessing/test/otbOGRLayerStreamStitchingFilter.cxx
      ee124eea
  3. 12 Jul, 2018 2 commits
    • Laurentiu Nicola's avatar
      ENH: Use std instead of vcl headers · eb259c64
      Laurentiu Nicola authored
      find \( -name "*.hxx" -or -name "*.h" -or -name "*.cxx" \) -not -path "*ThirdParty*" -print0 | xargs -0 sed -sri "s/vcl_(algorithm|complex|cmath)\.h/\1/g"
      
      find \( -name "*.hxx" -or -name "*.h" -or -name "*.cxx" \) -not -path "*ThirdParty*" -print0 | xargs -0 sed -sri "s/std::complex\.h/complex/g"
      
      find \( -name "*.hxx" -or -name "*.h" -or -name "*.cxx" \) -not -path "*ThirdParty*" -print0 | xargs -0 sed -sri 's/#include "(algorithm|cmath|complex)"/#include <\1>/g'
      eb259c64
    • Laurentiu Nicola's avatar
      ENH: Use math functions in std:: instead of vcl · fcbf830b
      Laurentiu Nicola authored
      find \( -name "*.hxx" -or -name "*.h" -or -name "*.cxx" \) -not -path "*ThirdParty*" -print0 | xargs -0 sed -sri "s/([^<])vcl_(adjacent_find|and|binary|binary_search|copy|copy_|count|count_if|equal|equal_range|fill|fill_n|find|find_end|find_first_of|find_if|for_each|generate|generate_n|generators_|heap|includes|inplace_merge|iter_swap|lexicographical_compare|lower_bound|make_heap|max|min|max_element|merge|merge_|min_element|mismatch|next_permutation|nth_element|partial_sort|partial_sort_copy|partition|stable_partition|partitions_|pop_heap|prev_permutation|push_heap|random_shuffle|remove|remove_copy|remove_copy_if|remove_if|replace|replace_copy|replace_copy_if|replace_if|reverse|reverse_copy|rotate|rotate_copy|search|search_n|set_difference|set_intersection|set_symmetric_difference|set_union|sort|sort_|sort_heap|stable_sort|swap|swap_|swap_ranges|transform|unique|unique_copy|upper_bound|bitset|abs|acos|asin|atan|atan2|ceil|cos|cosh|exp|fabs|floor|fmod|frexp|ldexp|log|log10|modf|pow|sin|sinh|sqrt|tan|tanh|complex|real|imag|arg|norm|conj|polar|jmp_buf|longjmp|sig_atomic_t|raise|signal|va_list|ptrdiff_t|size_t|FILE|fpos_t|fopen|fclose|feof|ferror|fflush|fgetc|fgetpos|fgets|fwrite|fread|fseek|ftell|perror|clearerr|rename|fputc|fputs|freopen|fsetpos|getc|getchar|gets|putc|putchar|puts|rewind|setbuf|setvbuf|tmpfile|tmpnam|ungetc|printf|sprintf|fprintf|vprintf|vsprintf|vfprintf)/\1std::\2/g"
      
      find \( -name "*.hxx" -or -name "*.h" -or -name "*.cxx" \) -not -path "*ThirdParty*" -print0 | xargs -0 sed -sri "s/<<vcl_log/<<std::log/g"
      fcbf830b
  4. 07 Jun, 2018 1 commit
  5. 16 Mar, 2018 1 commit
  6. 12 Mar, 2018 1 commit
  7. 23 Feb, 2018 1 commit
  8. 19 Feb, 2018 1 commit
  9. 18 Jul, 2017 2 commits
  10. 03 May, 2017 1 commit
  11. 02 May, 2017 1 commit
  12. 08 Mar, 2017 2 commits
  13. 01 Jul, 2016 1 commit
  14. 16 Jun, 2016 2 commits
    • Manuel Grizonnet's avatar
      STYLE: Use ITK_NULLPTR to utilize c++11 features · 0f26e689
      Manuel Grizonnet authored
          Where available, use c++11 features to identify
          potential nullptr usage errors.
      
          python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-nullptr -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Modules/*/*/app/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-nullptr-log.txt
      
          find . -type f -print -name "*.h" -o -name "*.txx" -o -name "*.cxx" |xargs perl -pi -e 's/nullptr/ITK_NULLPTR/g'
      0f26e689
    • Manuel Grizonnet's avatar
      ENH: Explicitly recognize virtual functions in applications · 29522e41
      Manuel Grizonnet authored
              clang-tidy tool can insert missing override keyword as a macro so that missing [optional] virtual identifiers can be easily added.
      
              build otb with clang 3.8 and use cmake option CMAKE_EXPORT_COMPILE_COMMANDS=ON. Most modules and third parties have been activated.
      
              #Run clang modernize check using utility script which allow to process the code in parallel (only on Applications directory)
              python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-override -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/Modules/Applications/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/Applications/*/app/*.cxx  > ~/temporary/run-clang-tidy-app-log.txt
      
              #Replace override by ITK macro (to maintain compat with c++98) in Modules/Applications
              find . -type f -print -name "*.cxx" |xargs perl -pi -e 's/\ override/\ ITK_OVERRIDE/g'
      29522e41
  15. 04 Jan, 2016 1 commit
    • Rashad Kanavath's avatar
      ENH: apply spelling.patch from DebianGIS · 8cafd175
      Rashad Kanavath authored
      This is a big one without much harm. It fixes incorrect spelling
      and grammer when packaging OTB 5.0.0 and 5.2.0 for Debian.
      Most of these changes are done by developers at DebianGIS.
      For more info, I include the original patch header below.
      Description: Fix some spelling errors to silence lintian
      enabling  to concentrate on the real problem.
      Author: Andreas Tille <tille@debian.org>
      Author: Rashad Kanavath <rashad.kanavath@c-s.fr>
      Author: Bas Couwenberg <sebastic@xs4all.nl>
      Last-Update: 2015-12-22
      8cafd175
  16. 09 Dec, 2015 1 commit
  17. 28 Oct, 2015 1 commit
  18. 04 May, 2015 1 commit
  19. 25 Feb, 2015 2 commits
  20. 20 Feb, 2015 1 commit
  21. 18 Feb, 2015 1 commit
  22. 28 Oct, 2014 1 commit
  23. 29 Nov, 2013 1 commit
  24. 28 Nov, 2013 1 commit
  25. 19 Nov, 2013 1 commit
  26. 15 Nov, 2013 1 commit
  27. 24 Oct, 2013 2 commits
  28. 23 Oct, 2013 2 commits
  29. 22 Oct, 2013 2 commits
  30. 21 Oct, 2013 2 commits
  31. 17 Oct, 2013 1 commit