GitLab

This reverts commit a1aa949e.

ENH: Moved mvdUseInDebug() and mvdUseInRelease() macros into otbConfigure.h.in as otbUseInDebug() and otbUseInRelease().

    Where available, use c++11 features to identify
    potential nullptr usage errors.

    python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-nullptr -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Modules/*/*/app/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-nullptr-log.txt

    find . -type f -print -name "*.h" -o -name "*.txx" -o -name "*.cxx" |xargs perl -pi -e 's/nullptr/ITK_NULLPTR/g'

Used the following command:

find . \( -iname *.txx -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_txx/otb$1_txx/g;' {} \;
find . \( -iname *.h -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_h/otb$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

    clang-tidy tool can insert missing override keyword as a macro so that missing [optional] virtual identifiers can be easily added.

    build otb with clang 3.8 and use cmake option CMAKE_EXPORT_COMPILE_COMMANDS=ON. Most modules and third parties have been activated.

    #Save override occurences in otb code
    cd src/Modules ; grep -nR "override" * > ~/temporary/override_otb.txt

    #Run clang modernize check using utility script which allow to process the code in parallel
    python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-override -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-log.txt

    #Replace override by ITK macro (to maintain compat with c++98)
    find . -type f -print -name "*.h" -o -name "*.txx" |xargs perl -pi -e 's/\ override/\ ITK_OVERRIDE/g'

This patch is authored by Bas Couwenberg <sebastic@xs4all.nl>
from DebianGIS team. spelling errors were encountered when
updating OTB debian package for 5.2.1.
https://bugs.orfeo-toolbox.org/view.php?id=1143

Adapted from the patch provided by sebastic (see
https://bugs.orfeo-toolbox.org/view.php?id=1142)

Allow to maintain compatibility with itk 4.9 conditional (ITK do not maintain
backward compatibility with FundamentalTypes after release 4.9)

Adapted from the patch provided by sebastic (see
https://bugs.orfeo-toolbox.org/view.php?id=1142)

Allow to maintain compatibility with itk 4.9 conditional (ITK do not maintain
backward compatibility with FundamentalTypes after release 4.9)

(cherry picked from commit c7b301d7)

Factorize forward and reverse test cases to enable more underlying iterator
types to be tested.
Remove the wrapped Set() method to support const iterators. Set can still be
reached with GetImageIterator().
Also add a missing const in otbSubsampledImageRegionIterator that the new test
revealed.

This is a big one without much harm. It fixes incorrect spelling
and grammer when packaging OTB 5.0.0 and 5.2.0 for Debian.
Most of these changes are done by developers at DebianGIS.
For more info, I include the original patch header below.
Description: Fix some spelling errors to silence lintian
enabling  to concentrate on the real problem.
Author: Andreas Tille <tille@debian.org>
Author: Rashad Kanavath <rashad.kanavath@c-s.fr>
Author: Bas Couwenberg <sebastic@xs4all.nl>
Last-Update: 2015-12-22

- Move declaration of GDAL_CONFIG_CHECKING in otb-module-init.cmake to ensure gdal configuration in all cases (if statement)
- OTBCommon module needs to depend on OTBGDAL as GDAL module has to set OTB_USE_GDAL_20 before configuring otbConfigure.h
- Set mode to STATUS for GDAL version >= to 2.0

All these issues were found compiling gdal trunk (2.1.0dev) with clang 3.5.

ENH: Adding proper detection of gdal version >= 2.0 and report in configuration header. The class OGRVersionProxy serves as a proxy containing #if switches between gdal 1.x and gdal 2.x implementations

BUG: Fixing bug #983 (Split map was not correctly estimated when ImageRegion did not start at [0,0]). Added two tests for this case as well.

BUG: Fixing bug #983 (Split map was not correctly estimated when ImageRegion did not start at [0,0]). Added two tests for this case as well.