OGRLayerStreamStitchingFilter CommitTransaction fail is some cases
Mantis Issue 1139, reported by mgrizonnet, assigned to mgrizonnet, created: 2016-02-04
Catching returns value from ORG CommitTranscation methods show that transaction fails in some cases in Segmentation application:
See tests related to the application here:
http://dash.orfeo-toolbox.org/testDetails.php?test=37099501&build=216910
I comment this exception for now but there is something to investigate to understand why the transaction commit fail :
https://git.orfeo-toolbox.org/otb.git/commitdiff/6b2a9f2994dadd976bf5fbedaa87ec46d7ea7b80
Note that the produce sqlite files in related tests seem valide (geometry validation in qgis)
1454583249 - julienWe have 5 newly broken tests on our dashboard with this error as of today :
http://dash.orfeo-toolbox.org/viewTest.php?onlydelta&buildid=216910
1454583358 - julienI would suspect the following commit to not just fix warnings:
https://git.orfeo-toolbox.org/otb.git/commit/6b30eed232dadea589e8b7c7b32eedff42013abd
1454583702 - julienFrom gdal documentation:
"If no transaction is active, or the commit fails, will return OGRERR_FAILURE. Datasources which do not support transactions will always return OGRERR_UNSUPPORTED_OPERATION."
I think that maybe the dataset format we are using does not support transactions.
I can also read that "Depending on drivers, this may or may not abort layer sequential readings that are active."
So we could check for OGRERR_UNSUPPORTED_OPERATION return code as well, but the best would IMHO to check for the transaction capability using :
GDALDataset::TestCapability(ODsCTransactions)
See: