otb merge requestshttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests2018-07-05T08:56:16Zhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/117On Revert shark2018-07-05T08:56:16ZAntoine RegimbeauOn Revert sharkAbout #1592 :
What should we do? We have a branch that revert the modification done for the development version of Shark, and we also have a possible [release of Shark](https://github.com/Shark-ML/Shark/issues/231).
Discussions are o...About #1592 :
What should we do? We have a branch that revert the modification done for the development version of Shark, and we also have a possible [release of Shark](https://github.com/Shark-ML/Shark/issues/231).
Discussions are open.6.6.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/26Update Shark Random Forest implementation2018-05-24T06:45:42ZManuel GrizonnetUpdate Shark Random Forest implementation*[Merge request copy from previous RFC-127 by @jinglada on OTB wiki: https://wiki.orfeo-toolbox.org/index.php/Request_for_changes-127:_Update_Shark_Random_Forest_implementation]*
### Summary
There has been some recent work on the R...*[Merge request copy from previous RFC-127 by @jinglada on OTB wiki: https://wiki.orfeo-toolbox.org/index.php/Request_for_changes-127:_Update_Shark_Random_Forest_implementation]*
### Summary
There has been some recent work on the Random Forest implementation in Shark which would be nice to have in OTB. It is a complete reimplementation to improve memory footprint and speed.
### Rationale
There has been some recent work on the Random Forest implementation in Shark which would be nice to have in OTB. It is a complete reimplementation to improve memory footprint and speed.
There is a minor API change which needs a small change in otbSharkRandomForestsMachineLearningModel.h.
As Shark is not still widely use in OTB and most users use the package version in OTB Superbuild (which include a specific version of Shark), I would like to suggest to don't take time to maintain backward compatibility of OTB code with previous versions of Shark. Shark library evolves quite quickly and there is no reason to maintain backward compat which will add boilerplate code in MachineLearningModel. OTB users which want to use Shark have the expertise IMO to update their client code (these are really small changes). Moreover for end user of OTB machine learning applications those changes have no impact.
### Implementation Details
#### Classes and files
Modules/Learning/Supervised/include/otbSharkRandomForestsMachineLearningModel.h
Modules/Learning/Supervised/include/otbSharkRandomForestsMachineLearningModel.txx
SuperBuild/CMake/External_shark.cmake
SuperBuild/patches/SHARK/shark-2-ext-num-literals-all.diff
SuperBuild/patches/SHARK/shark-2-find-boost-all.diff
#### Applications
No impact on otb apps
#### Tests
Some baseline should probably be updated
### Documentation
List or link documentation modifications that were made (doxygen, example, software guide, application documentation, cookbook).
### Additional notes
The superbuild version of Shark have been updated to a specific tag version (3394e5f553e020ef5b093f388bdba29247600dbd) has there is not yet Shark official release. Don't think that it is an issue a****s6.6.0Guillaume PaseroGuillaume Paserohttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/998PKG: add LERC as external dep, compile gdal with it2024-02-16T15:06:01ZTristan LaurentPKG: add LERC as external dep, compile gdal with itAdd LERC support to gdal dependency. For this libTIFF used by Gdal must have LERC support. Thus LERC is added in libtiff and gdal deps buildAdd LERC support to gdal dependency. For this libTIFF used by Gdal must have LERC support. Thus LERC is added in libtiff and gdal deps build10.0.0Tristan LaurentTristan Laurenthttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/935Migrate expat from sourceforge to github2022-09-27T07:13:58ZLuc HermitteMigrate expat from sourceforge to github#### Summary
Build fails because a new version of expat is out.
#### Rationale
Builds should **never** fail when a new version of expat, or any other 3rd party component, is out.
#### Implementation Details
Expat is officially migra...#### Summary
Build fails because a new version of expat is out.
#### Rationale
Builds should **never** fail when a new version of expat, or any other 3rd party component, is out.
#### Implementation Details
Expat is officially migrating from SF to GH since 2022-01-09.
Also, downloading expat packets from GH will be more resilient as the URLs aren't discarded every time a new version is out.
Note: at this moment, there exists a version 2.4.9, but this commit/MR **only** focuses on changing the official source repository.
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
---
***Check before merging:***
* All discussions are resolved
* At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
* The feature branch is (reasonably) up-to-date with the base branch
* Dashboard is green
* Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
* Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.2.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/919Update dependencies2022-08-29T12:28:00ZJulien OsmanUpdate dependencies#### Summary
Update:
- [ ] Curl
- [x] Expat
- [x] Fftw
- [ ] Freetype
- Gdal (see !921)
- [x] Geos
- [x] Geotiff
- [ ] Gsl
- [ ] Hdf5
- [x] Jpeg
- [x] Libsvm
- [ ] Netcdf
- [x] Opencv
- [ ] Openjpeg
- [x] Pcre
- [x] Proj
- [x] Tiff
##...#### Summary
Update:
- [ ] Curl
- [x] Expat
- [x] Fftw
- [ ] Freetype
- Gdal (see !921)
- [x] Geos
- [x] Geotiff
- [ ] Gsl
- [ ] Hdf5
- [x] Jpeg
- [x] Libsvm
- [ ] Netcdf
- [x] Opencv
- [ ] Openjpeg
- [x] Pcre
- [x] Proj
- [x] Tiff
#### Notes
<!--- List remaining open issues if any, and additional notes. -->
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.1.0Julien OsmanJulien Osmanhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/911Upgrade zlib and gdal2022-05-09T09:51:21ZJulien OsmanUpgrade zlib and gdal#### Summary
Upgrade dependencies:
- GDAL to 3.4.2
- Zlib to 1.2.12
Fixes a formating issue in the documentation.
Set OTB version to 8.0.1 in CMakeLists.
#### Rationale
Fix #2271
Fix #2269
Fix [1299](https://forum.orfeo-tool...#### Summary
Upgrade dependencies:
- GDAL to 3.4.2
- Zlib to 1.2.12
Fixes a formating issue in the documentation.
Set OTB version to 8.0.1 in CMakeLists.
#### Rationale
Fix #2271
Fix #2269
Fix [1299](https://forum.orfeo-toolbox.org/t/documentation-format-issue/1299)
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.1Julien OsmanJulien Osmanhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/910Correct regex to parse muparser version2022-05-09T09:51:21ZJulien OsmanCorrect regex to parse muparser version#### Summary
Closes #2274
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes fro...#### Summary
Closes #2274
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.1Julien OsmanJulien Osmanhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/909Update the warning message that tells the required version of Python is 3.82022-05-09T09:51:21ZJulien OsmanUpdate the warning message that tells the required version of Python is 3.8#### Summary
Update the warning message to tells the required version of Python is 3.8
#### Rationale
When installing the OTB through the officcial package, a warning message informs the user that the Python API requires Python3.5. Th...#### Summary
Update the warning message to tells the required version of Python is 3.8
#### Rationale
When installing the OTB through the officcial package, a warning message informs the user that the Python API requires Python3.5. This is not correct, since OTB 8.0.0, Python3.8 is required (Python 3.7 for windows)
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.1Julien OsmanJulien Osmanhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/902Remove visualization modules2023-02-21T10:20:42ZJulien OsmanRemove visualization modules#### Summary
Remove all the dependencies related to visualization (Qt, OpenGL, etc)
#### Rationale
Fix #2254
#### Implementation Details
See #2254
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contr...#### Summary
Remove all the dependencies related to visualization (Qt, OpenGL, etc)
#### Rationale
Fix #2254
#### Implementation Details
See #2254
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit9.0.0Thibaut ROMAINThibaut ROMAINhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/886Fix FindNumpy.cmake2022-02-07T08:32:44ZCédric TraizetFix FindNumpy.cmake#### Summary
the FindNumpy.cmake file packaged in OTB is broken when used with cmake 3.12 because te name of the Python executable variable has changed in CMake form `PYTHON_EXECUTABLE` to `Python_EXECUTABLE`. As a result, the script re...#### Summary
the FindNumpy.cmake file packaged in OTB is broken when used with cmake 3.12 because te name of the Python executable variable has changed in CMake form `PYTHON_EXECUTABLE` to `Python_EXECUTABLE`. As a result, the script recompiling the Python bindings was not able to find Numpy (for example in Ubuntu 20 where the default is cmake 3.13.3)
This MR fixes this script to handle both cmake <3.12 and cmake >= 3.12
bug reported on [this note](https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/issues/2240#note_98530)
TODO; test the generated packages on Ubuntu 18 (cmake 3.10) and Ubuntu 20 (cmake 3.16)
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.0Thibaut ROMAINThibaut ROMAINhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/880Don't search and package boost date time2022-02-07T08:32:44ZCédric TraizetDon't search and package boost date time#### Summary
In !868 boost datetime has been replaced by std::chrono and the date library from Howard Hinnant. However the Cmake code of OTB still search for the boost library, which results of it being packaged. This MR remove datetime...#### Summary
In !868 boost datetime has been replaced by std::chrono and the date library from Howard Hinnant. However the Cmake code of OTB still search for the boost library, which results of it being packaged. This MR remove datetime from the list of requied boost libraries in OTB
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/865Update geospatial libraries versions in Superbuild2022-01-04T19:38:51ZCédric TraizetUpdate geospatial libraries versions in Superbuild#### Summary
Update the version of several OTB dependencies in the Superbuild for Linux and Macos:
* [x] SQLITE: 3.8 to 3.36. SQLITE > 3.11 is required to build PROJ > 7.0.0. See https://github.com/OSGeo/PROJ/issues/1718
* [x] PROJ: 6....#### Summary
Update the version of several OTB dependencies in the Superbuild for Linux and Macos:
* [x] SQLITE: 3.8 to 3.36. SQLITE > 3.11 is required to build PROJ > 7.0.0. See https://github.com/OSGeo/PROJ/issues/1718
* [x] PROJ: 6.2.1 to 8.1.1 : `proj-1-cmakefixes-all.diff` is not required anymore with https://github.com/OSGeo/PROJ/issues/1479. PROJ now have TIFF and CURL as (optional) dependencies. As these libraries are already built by the Superbuild they can be used in PROJ. See [RFC4](https://proj.org/community/rfc/rfc-4.html).
* [x] GEOS: 3.6.5 to 3.6.9
* [x] GEOTIFF: Already up to date
* [x] GDAL: 3.2.2 to 3.4.0 : baselines should be updated (see notes)
#### Rationale
We noted some differences in baseline tests when compiling OTB with more recent versions of the dependencies (in a conda environment), in particular slight difference in the extent of the output polygons of some tests have been noticed. This might be caused by changes in the dependencies (maybe in geos)
#### Notes
Some tests were broken because the baselines were generated before the fixes of this [GDAL issue](https://github.com/OSGeo/gdal/issues/4591). These baselines have been updated
GDAL 3.2.2 is still used on Windows because of bugs when using SQLITE > 3.11. At the moment we don't know the cause of these error (SQLITE ? PROJ ? OTB ?). For release 8.0-rc1 GDAL 3.2.2 will be used
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/852Update to qt 5.152021-11-03T16:32:53ZThibaut ROMAINUpdate to qt 5.15Closes #2219Closes #22198.0.0Thibaut ROMAINThibaut ROMAINhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/842Superbuild: compatibility between QT5 and MySQL2021-08-11T10:08:38ZCédric TraizetSuperbuild: compatibility between QT5 and MySQL#### Summary
the `my_bool` type has been removed in MySQL>8.0.1. QT5 [has been updated](https://github.com/qt/qtbase/commit/82b4c79fb90c1a01165b96455ae48715c3059bbe) to take this change into account. However the fix is integrated into Q...#### Summary
the `my_bool` type has been removed in MySQL>8.0.1. QT5 [has been updated](https://github.com/qt/qtbase/commit/82b4c79fb90c1a01165b96455ae48715c3059bbe) to take this change into account. However the fix is integrated into Qt 5.12 and the superbuild uses Qt 5.11. This merge request add a patch to Qt in the Superbuild to add this change and fix compilation on platform using SQL>8.0.1 (e.g Uubntu 20.04)
There are already several patches from QT5 upstream in the Superbuild. We should probably upgrade to a more recent Qt version. At the moment Qt 5.11 is used because it is the last version compatible with Centos-6. But Centos-6 is not maintained anymore, and we have replaced the centos 6 job by a centos 7 job in the CI.
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/840Remove the "working around a kernel bug" warning during OTB binary package in...2021-08-06T15:11:41ZCédric TraizetRemove the "working around a kernel bug" warning during OTB binary package installation#### Summary
When installing OTB using a Linux binary package, it is possible to run into the following warning:
```
warning: working around a Linux kernel bug by creating a hole of 2113536 bytes in ‘./lib/libQt5Core.so.5.11.3’
```
Th...#### Summary
When installing OTB using a Linux binary package, it is possible to run into the following warning:
```
warning: working around a Linux kernel bug by creating a hole of 2113536 bytes in ‘./lib/libQt5Core.so.5.11.3’
```
This warning is produced by patchelf which has been used to change the rpaths of the binaries. There is not much we can do about this warning, and it can be safely ignored (cf [this issue](https://github.com/NixOS/patchelf/issues/92#issuecomment-265421041) on patchelf github). The warning has actually been removed in patchelf 0.10 (see [this commit](https://github.com/NixOS/patchelf/commit/c4deb5e9e1ce9c98a48e0d5bb37d87739b8cfee4)), and we use patchelf 0.9 in the packaging step (as a CMake external project).
I tried to update the version of patchelf in the Packaging project. I tried versions 0.10 and 0.12 (the last release). But in both cases I run into the bug described in [this issue](https://github.com/NixOS/patchelf/issues/45). The binaries are corrupted and output many "X" symbols on execution:
For example launching the EdgeExtraction applications leads:
```
This is the EdgeExtraction application, version 7.4.0
This application computes edge features on every pixel of the input image selected channel
Complete documentation: https://www.orfeo-toolbox.org/CookBook/Applications/app_EdgeExtraction.html or -help
Parameters:
MISSING -in <string> Input Image (mandatory)
MISSING -out <string> [pixel] Feature Output Image [pixel=uint8/uint16/int16/uint32/int32/float/double/cint16/cint32/cfloat/cdouble] (default value is float) (mandatory)
-channel <int32> Selected Channel (mandatory, default value is 1)
-filter <string> Edge feature [gradient/sobel/touzi] (mandatory, default value is gradient)
-filter.touzi.xradius <int32> X radius of the neighborhood (mandatory, default value is 1)
-filter.touzi.yradius <int32> Y radius of the neighborhood (mandatory, default value is 1)
-ram <int32> Available RAM (MB) (optional, off by default, default value is 256)
-progress <boolean> Report progress
-help <string list> Display long help (empty list), or help for given parameters keys
Use -help param1 [... paramN] to see detailed documentation of those parameters.
Examples:
otbcli_EdgeExtraction -in qb_RoadExtract.tif -channel 1 -out Edges.tif
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
```
This is annoying and I don't think updating to patchelf > 0.9 is a solution while this bug is not fixed.
In this MR I added a patch to remove the warning.
Maybe integrating the whole commit could be interesting (I don't know if it can be applied to patchelf 0.9 directly), as it might reduce the size of the OTB binary package (untested)
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.4.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/835Update Geotiff version in the Superbuild2021-07-29T08:42:31ZCédric TraizetUpdate Geotiff version in the Superbuild#### Summary
Update the GeoTiff version in the Superbuild from 1.5.1 to 1.7.0
See the [GeoTiff changelog](https://github.com/OSGeo/libgeotiff/blob/master/libgeotiff/NEWS) for more information.
This MR also includes a backport of !821....#### Summary
Update the GeoTiff version in the Superbuild from 1.5.1 to 1.7.0
See the [GeoTiff changelog](https://github.com/OSGeo/libgeotiff/blob/master/libgeotiff/NEWS) for more information.
This MR also includes a backport of !821.
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.4.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/822ENH: Update openCV version to 4.5.1 for the SuperBuild, update the baseline f...2021-11-08T16:20:45ZJulien OsmanENH: Update openCV version to 4.5.1 for the SuperBuild, update the baseline for GEOS#### Summary
Recently, GEOS's version in Debian's repositories was updated to 3.9.0. This new version brings [some minor updates to the algorithms](https://lists.osgeo.org/pipermail/geos-devel/2020-December/010003.html) that slightly ch...#### Summary
Recently, GEOS's version in Debian's repositories was updated to 3.9.0. This new version brings [some minor updates to the algorithms](https://lists.osgeo.org/pipermail/geos-devel/2020-December/010003.html) that slightly changes the [results of the segmentation](https://cdash.orfeo-toolbox.org/viewTest.php?onlyfailed&buildid=64721) in OTB. This changes are so small that the *symmetrical difference* in QGIS doesn't detect them. But they make the CI fail. To fix this (and to be homogeneous across all the platforms), it would be best to update this dependency in the SuperBuild. But OSSIM is not compatible with GEOS 3.9.0, so we need to wait until ossim is removed. The chosen solution is to add a new baseline especially for Debian.
The version of openCV was updated too, to 4.5.1. It also changes the results of the classification in OTB (see [1](https://cdash.orfeo-toolbox.org/testDetails.php?test=29410649&build=64964) and [2](https://cdash.orfeo-toolbox.org/testDetails.php?test=29410651&build=64964)). Even though the models are slightly different, the result is either as good or better. So we can safely update the version of openCV in the SuperBuild and the baseline.
#### Rationale
Closes #2197
#### Implementation Details
##### Classes and files
- Set the new version of openCV in `SuperBuild/CMake/External_opencv.cmake`.
##### Tests
- Add a new baseline with the new values obtained with GEOS 3.9.0
- Update the baseline for openCV 4.5.1
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.0Julien OsmanJulien Osmanhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/821Update EXPAT to version 2.4.12021-07-29T08:42:31ZJulien OsmanUpdate EXPAT to version 2.4.1#### Summary
The SuperBuild uses EXPAT version 2.3.0. This version is marked as "VULNERABLE" by the development team, and users are invited to use the version 2.4.1.
#### Implementation Details
Set the version of EXPAT to 2.4.1.
####...#### Summary
The SuperBuild uses EXPAT version 2.3.0. This version is marked as "VULNERABLE" by the development team, and users are invited to use the version 2.4.1.
#### Implementation Details
Set the version of EXPAT to 2.4.1.
#### Additional notes
It might be a good idea to backport this fix to OTB 7.3.1.
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.0Julien OsmanJulien Osmanhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/819Release 7.3 (integration into master)2021-07-06T07:42:39ZCédric TraizetRelease 7.3 (integration into master)#### Summary
Merge the release-7.3 branch into master.
This is part of the release process. See #2192
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check befor...#### Summary
Merge the release-7.3 branch into master.
This is part of the release process. See #2192
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.3.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/815Update expat version in Superbuild2021-04-23T09:11:52ZCédric TraizetUpdate expat version in Superbuild#### Summary
Update the expat version in Superbuild to v2.3.0 and use VS 2019 in Windows CI
#### Rationale
Because of security issues, the current version of EXPAT should not be used anymore. The version have been updated to 2.3.0.
T...#### Summary
Update the expat version in Superbuild to v2.3.0 and use VS 2019 in Windows CI
#### Rationale
Because of security issues, the current version of EXPAT should not be used anymore. The version have been updated to 2.3.0.
This version does not compile with VC14 (2015), therefore the VS studio version in Windows CI has been updated to VC14.20 (VS 2019). Note that this change is also required to use the C++17 standard (see !799)
#### Implementation Details
This is a backport of the work done by @thibrom in the [release-7.3](https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/commits/release-7.3/) branch.
#### Additional notes
See https://github.com/libexpat/libexpat/blob/R_2_2_8/expat/Changes#L6
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit8.0.0Cédric TraizetCédric Traizet