otb merge requestshttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests2022-01-06T12:54:47Zhttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/618Integration of the multiImageFileWriter in the application engine2022-01-06T12:54:47ZCédric TraizetIntegration of the multiImageFileWriter in the application engine#### Summary
Integration of the MultiImageFileWriter into the application engine.
Some applications have more than one output and therefore would benefit from synchronized writing :
* ImageClassifier : 3 dependents outputs : 1 ...#### Summary
Integration of the MultiImageFileWriter into the application engine.
Some applications have more than one output and therefore would benefit from synchronized writing :
* ImageClassifier : 3 dependents outputs : 1 mandatory output and two optional outputs
* SOMClassification : 2 independent outputs. (training step with optional som output, classification step with mandatory output)
* DimensionalityReduction : 2 optional dependent outputs
* MorphologicalMultiScaleDecompostion : 3 mandatory dependent outputs
* ComputeModulusAndPhase : 2 output sharing the same reader (reader -> modulusFilter -> out1 and reader -> phaseFilter -> out2)
* HooverCompareSegmentation : 2 dependent optional outputs
* MeanShiftSmoothing : 2 dependents outputs (1 mandatory 1 optional)
* BlockMatching : 2 dependents outputs (1 mandatory 1 optional)
* FineRegistration : 2 dependents outputs (1 mandatory 1 optional). The pipeline is split in two atm.
* StereoGridRectificationGridGenerator : 4 output (2 optional) but not streamable ?
With this merge request a multiImageFileWriter is created and configured in the WriteOutput method of the Application class.
MultiWriting should be enabled in applications by using `SetMultiWriting(true)` in the `DoInit()` of the application. It can be disabled for specific output by using the `multiwrite` extended filename parameter.
The OutputImageParameter class has been modified so it can register its associated writer to a multiImageFileWriter during the writer creation.
The MR also includes several bugfixes on the multiImageFileWriter
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/628Added 'double' application parameter type.2020-11-02T10:56:25Zguillaume pernotAdded 'double' application parameter type.Closes #1971Closes #19717.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/673Smoothing application enhancement2020-03-23T16:53:31ZCédric TraizetSmoothing application enhancement#### Summary
Some modifications of the Smoothing application. In particular the Gaussian mode now has two additional parameters : `type.gaussian.maxerror` and `type.gaussian.maxwidth`. These parameters were available in the ITK filter...#### Summary
Some modifications of the Smoothing application. In particular the Gaussian mode now has two additional parameters : `type.gaussian.maxerror` and `type.gaussian.maxwidth`. These parameters were available in the ITK filter, but were not exposed in the application
Closes #1961
#### Implementation Details
##### Applications
Smoothing :
* new parameter `type.gaussian.maxerror` : The algorithm will size the discrete kernel so that the error resulting from truncation of the kernel is no greater than `type.gaussian.maxerror`
* new parameter `type.gaussian.maxwidth` : Set the kernel to be no wider than maxwidth pixels, even if `type.gaussian.maxerror` demands it.
* the radius parameter has been renamed into stdev (because this is what it is, see the TODO in code)
* Some modernization (auto, RegisterPipeline())
FastNLMeans :
* Some modernization (auto, RegisterPipeline())
##### Tests
The tests for the Smoothing application have been updated:
* New test for the Gaussian mode (there was no test for this mode)
* New test for the Anisotropic mode (there was no test for this mode). Note that I needed to set a tolerance value for this test (1e-6), because the result were different on windows 8 (x86). The differences are probably caused by numerical error, and we can't do much about it anyway because we are using an ITK filter.
* The `apTvUtSmoothingTest_InXML` now depends on the `apTvUtSmoothingTest_OutXML` test, instead of using a stored baseline.
* The `apTvUtSmoothingTest` has been removed, there is no need to test 3 times the `mean` mode with the same parameters. (see InXML and OUTXML tests).
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/703Release 7.12020-03-21T11:33:40ZCédric TraizetRelease 7.1#### Summary
OTB 7.1.0 is ready to be released !
This branch contains the change of version and the bug corrections added since the release candidate.
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Cont...#### Summary
OTB 7.1.0 is ready to be released !
This branch contains the change of version and the bug corrections added since the release candidate.
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/701Error when opening ENVI datasets2020-03-13T07:57:31ZCédric TraizetError when opening ENVI datasets#### Summary
Reading a ENVI dataset with `ImageFileReader` result in the following error :
```
ERROR 1: The selected file is an ENVI header file, but to open ENVI datasets, the data file should be selected instead of the .hdr file...#### Summary
Reading a ENVI dataset with `ImageFileReader` result in the following error :
```
ERROR 1: The selected file is an ENVI header file, but to open ENVI datasets, the data file should be selected instead of the .hdr file. Please try again selecting the data file corresponding to the header file: CupriteAVIRISSubset.hdr
```
even is the file is successfully opened.
#### Analysis
When reading the input image (in `ImageFileReader::GenerateOutputInformation`), there is different ways to read the geometric information and build the `otb::ImageKeywordList`, by order of priority :
1. don't read anything if the extended filename `&skipgeom` is set to `true`
1. Try to read an external geom file provided by the extended filename `&geom`
1. Try to read an external geom file attached to the input image (`inputfilename.geom`)
1. Try to read it from the input image using `ossimPluginProjection`
1. Try to read it from the input image using `ossimProjection`
1. Try to read it from the input image using gdal rcp tags.
Then for each attached file
1. try to read it from the attached file using `ossimPluginProjection`
1. Try to read it from the input image using `ossimProjection`
1. Try to read it from the input image using gdal rcp tags.
The "attached file" are a list of files associated with the input filename, given by the gdal driver used to open the input image, in this case the ENVI driver. For the ENVI driver the attached files are the header and eventually the stat file.
In the case of the input data considered in this issue, there is no geom information attached, and no rpc in the envi dataset, so all 9 cases are tested and don't return anything. In particular steps 7 8 and 9 are applied to the `.hdr` file.
In particular in case 9 OTB tries to read the .hdr file as a GDAL dataset. `GDALIdentifyDriver(...)` is used. This method tries to find a driver able to open the file in the list of available gdal drivers. To do so for each driver the Identify() method of the driver is called, and if this method is not implemented (which is the case for the ENVI driver) the driver tries to open the file. So at some point the ENVI driver tries to open the .hdr file, resulting in this error. The driver the return a null dataset, step 9 does not return anything, no keyword list is built and the application continue.
So this error message is just noise. But it is a bit confusing, so it would be nice to be able to remove it ...
It is important to note that if there were RCPs in the ENVI dataset they would be read by GDAL in step 6, not 9 (even if the information is stored in the .hdr)
closes #1995
#### solution
Don't try to open the hdr file in `ossimKeywordList`
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/699Fix listview parameter in TrainImagesClassifier2020-03-08T19:00:30ZCédric TraizetFix listview parameter in TrainImagesClassifier#### Summary
`TrainImagesClassifier` is a composite application chaining several learning applications. This applications has a listView parameter `sample.vfn` connected to a `PolygonClassStatistics`, a `SampleSelection` and a `TrainVec...#### Summary
`TrainImagesClassifier` is a composite application chaining several learning applications. This applications has a listView parameter `sample.vfn` connected to a `PolygonClassStatistics`, a `SampleSelection` and a `TrainVectorClassifier` application.
The `io.vd` input vector data source of `TrainImagesClassifier` is connected to the `vec` input vector data of `PolygonClassStatistics` and when the parameters of `TrainImagesClassifier` the parameters of `PolygonClassStatistics` are also updated. This means the listView parameter is connected to the input vector data. The choice list is the available fields in `io.vd` and the selected item is the index of `sample.vfn` in this choice list.
It is important to note that sharing a ListView parameter is not sharing the string value given to the parameter (or stringList), the whole ListView is shared, i.e. the choice list and the selected item(s).
However the input vector of the `TrainVectorClassifier` application is not the same one, it is a temporary vector created by `SampleExtraction` and its fields are not the same. The selected item is never updated again, and index of the selected item is not necessarily the right one.
In most case it is not a problem (i.e. the selected item is still the right field). However in the case described on this [forum post](https://forum.orfeo-toolbox.org/t/trainimagesclassifier-execution-error/582/3) the field used for classification is not the right one, it is a field containing the class name and during training a `stod` exception is raised while attempting to convert the wrong field into an integer. I don't know why this specific case fails and the other don't (e.g. the tests).
This merge request is a fix for this bug. `sample.vfn` is not connected to the `cfield` of `TrainImageClassifier`. Instead `cfield` is initialized with the value given to `sample.vfn`, i.e. the actual field name.
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/690Fix proj lib develop2020-03-03T16:04:51ZCédric TraizetFix proj lib develop#### Summary
When using GDAL 3 we should set the `PROJ_LIB` to `xdk/share/proj`. Otherwise we get errors like :
```
2020-02-12 17:56:47 (INFO) EdgeExtraction: Default RAM limit for OTB is 256 MB
2020-02-12 17:56:47 (INFO) EdgeExt...#### Summary
When using GDAL 3 we should set the `PROJ_LIB` to `xdk/share/proj`. Otherwise we get errors like :
```
2020-02-12 17:56:47 (INFO) EdgeExtraction: Default RAM limit for OTB is 256 MB
2020-02-12 17:56:47 (INFO) EdgeExtraction: GDAL maximum cache size is 794 MB
2020-02-12 17:56:47 (INFO) EdgeExtraction: OTB will use at most 12 threads
ERROR 1: PROJ: pj_obj_create: Cannot find proj.db
ERROR 1: PROJ: createGeodeticReferenceFrame: Cannot find proj.db
ERROR 1: PROJ: proj_as_wkt: Cannot find proj.db
ERROR 1: PROJ: createGeodeticReferenceFrame: Cannot find proj.db
ERROR 1: PROJ: pj_obj_create: Cannot find proj.db
ERROR 1: PROJ: proj_as_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_create_from_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_create_from_wkt: Cannot find proj.db
ERROR 1: PROJ: pj_obj_create: Cannot find proj.db
ERROR 1: PROJ: proj_as_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_as_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_create_from_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_create_from_database: Cannot find proj.db
2020-02-12 17:56:47 (INFO): Estimated memory for full processing: 38.8794MB (avail.: 256 MB), optimal image partitioning: 1 blocks
2020-02-12 17:56:47 (INFO): File /tmp/out.tif will be written in 1 blocks of 1000x1000 pixels
Writing /tmp/out.tif...: 100% [**************************************************] (0s)
```
Note : this branch is already merged in the `release-7.1` branch.
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.7.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/685Force upload2020-03-03T16:04:38Zguillaume pernotForce upload7.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/686Fixed anaconda upload return code2020-03-03T16:04:35Zguillaume pernotFixed anaconda upload return code7.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/687Added include std::array2020-03-03T16:00:59Zguillaume pernotAdded include std::arrayCloses #2023Closes #20237.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/613Additional tests for the ExtractROI application2020-02-26T08:22:10ZCédric TraizetAdditional tests for the ExtractROI application#### Summary
Currently, the ExtractROI application is only tested in the case where the output is the same as the input, for example if its parameters are not compliant with the input image. it is also important to test the case where...#### Summary
Currently, the ExtractROI application is only tested in the case where the output is the same as the input, for example if its parameters are not compliant with the input image. it is also important to test the case where the application works correctly. This MR adds the 9 following tests:
* Mode standard (test with `sizex` `sizey` `startx` and `starty`) + cl parameter
* Mode Fit:
* case with a reference image
* case with a reference vector
* Mode Extent (test with `mode.extent.ulx`, `mode.extent.uly` ,`mode.extent.lrx` and `mode.extent.lry`:
* case with unit = `pxl`
* case with unit = `phy`
* case with unit = `lonlat`
* Mode Radius (test with `radius.r` `radius.cs` and `radius.cy` :
* case with center unit `pxl` and radius unit `pxl`
* case with center unit `phy` and radius unit `phy`
* case with center unit `lonlat` and radius unit `pxl`
This MR also corrects a bug in fit vector mode, and in the extent mode with physical units, where some variable were redefined in a scope.
Closes issue #1931
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/678BUG: Fix warnings and possible UB in `VariadicInputsImageFilter::SetInputsImpl`2020-02-25T14:18:48ZLaurențiu NicolaBUG: Fix warnings and possible UB in `VariadicInputsImageFilter::SetInputsImpl`#### Summary
Avoid returning a temporary value from the function.
#### Rationale
Spotted on Debian Testing with GCC 9.2.1:
```
/otb/Modules/Core/Functor/include/otbVariadicInputsImageFilter.h: In instantiation of 'auto otb::...#### Summary
Avoid returning a temporary value from the function.
#### Rationale
Spotted on Debian Testing with GCC 9.2.1:
```
/otb/Modules/Core/Functor/include/otbVariadicInputsImageFilter.h: In instantiation of 'auto otb::VariadicInputsImageFilter<TOuptut, TInputs>::SetInputsImpl(Tuple&, std::index_sequence<Is ...>) [with Tuple = std::tuple<otb::VectorImage<float, 2>*>; long unsigned int ...Is = {0}; TOuptut = otb::VectorImage<float, 2>; TInputs = {otb::VectorImage<float, 2>}; std::index_sequence<Is ...> = std::integer_sequence<long unsigned int, 0>]':
/otb/Modules/Core/Functor/include/otbVariadicInputsImageFilter.h:125:5: required from 'void otb::VariadicInputsImageFilter<TOuptut, TInputs>::SetInputs(TInputs* ...) [with TOuptut = otb::VectorImage<float, 2>; TInputs = {otb::VectorImage<float, 2>}]'
/otb/Modules/Applications/AppIndices/app/otbRadiometricIndices.cxx:260:46: required from here
/otb/Modules/Core/Functor/include/otbVariadicInputsImageFilter.h:148:91: warning: returning temporary initializer_list does not extend the lifetime of the underlying array [-Winit-list-lifetime]
148 | return std::initializer_list<int>{(this->template SetInput<Is>(std::get<Is>(t)), 0)...};
| ^
```
#### Copyright
The copyright owner is Laurențiu Nicola (CS ROMANIA) and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit
7.1.0Laurențiu NicolaLaurențiu Nicolahttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/692add 7.1 to available CookBook versions2020-02-19T08:51:32ZCédric Traizetadd 7.1 to available CookBook versions#### Summary
Add 7.1 to available CookBook versions (release candidate)
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions...#### Summary
Add 7.1 to available CookBook versions (release candidate)
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0Cédric TraizetCédric Traizethttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/689Feat conda build2020-02-13T18:20:10Zguillaume pernotFeat conda build7.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/684Export PROJ_LIB in env scripts2020-02-12T22:53:19ZCédric TraizetExport PROJ_LIB in env scripts#### Summary
When using GDAL 3 we should set the `PROJ_LIB` to `xdk/share/proj`. Otherwise we get errors like :
```
2020-02-12 17:56:47 (INFO) EdgeExtraction: Default RAM limit for OTB is 256 MB
2020-02-12 17:56:47 (INFO) EdgeExtractio...#### Summary
When using GDAL 3 we should set the `PROJ_LIB` to `xdk/share/proj`. Otherwise we get errors like :
```
2020-02-12 17:56:47 (INFO) EdgeExtraction: Default RAM limit for OTB is 256 MB
2020-02-12 17:56:47 (INFO) EdgeExtraction: GDAL maximum cache size is 794 MB
2020-02-12 17:56:47 (INFO) EdgeExtraction: OTB will use at most 12 threads
ERROR 1: PROJ: pj_obj_create: Cannot find proj.db
ERROR 1: PROJ: createGeodeticReferenceFrame: Cannot find proj.db
ERROR 1: PROJ: proj_as_wkt: Cannot find proj.db
ERROR 1: PROJ: createGeodeticReferenceFrame: Cannot find proj.db
ERROR 1: PROJ: pj_obj_create: Cannot find proj.db
ERROR 1: PROJ: proj_as_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_create_from_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_create_from_wkt: Cannot find proj.db
ERROR 1: PROJ: pj_obj_create: Cannot find proj.db
ERROR 1: PROJ: proj_as_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_as_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_create_from_wkt: Cannot find proj.db
ERROR 1: PROJ: proj_create_from_database: Cannot find proj.db
2020-02-12 17:56:47 (INFO): Estimated memory for full processing: 38.8794MB (avail.: 256 MB), optimal image partitioning: 1 blocks
2020-02-12 17:56:47 (INFO): File /tmp/out.tif will be written in 1 blocks of 1000x1000 pixels
Writing /tmp/out.tif...: 100% [**************************************************] (0s)
```
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/681ENH: allow HTTP GDAL datasets2020-02-10T19:49:50ZLaurențiu NicolaENH: allow HTTP GDAL datasets#### Summary
Allow `IOGDAL` to open HTTP and HTTPS datasets.
#### Rationale
These were disabled in 6b1a62701acab46bab770783ccdf4a7f9b4c2567 as a work-around for a pre-GDAL 1.11 bug. We no longer support GDAL 1, let's remove this...#### Summary
Allow `IOGDAL` to open HTTP and HTTPS datasets.
#### Rationale
These were disabled in 6b1a62701acab46bab770783ccdf4a7f9b4c2567 as a work-around for a pre-GDAL 1.11 bug. We no longer support GDAL 1, let's remove this check and see what happens.
#### Copyright
The copyright owner is Laurențiu Nicola (CS ROMANIA) and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0Laurențiu NicolaLaurențiu Nicolahttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/679COMP: Remove RemoteSensingRegion assignment operator2020-02-10T19:49:18ZLaurențiu NicolaCOMP: Remove RemoteSensingRegion assignment operator#### Summary
The default copy and move constructors and assignment operators are fine, there's no need to implement them manually.
#### Rationale
Spotted on Debian Testing with GCC 9.2.1:
```
In file included from /otb/Modul...#### Summary
The default copy and move constructors and assignment operators are fine, there's no need to implement them manually.
#### Rationale
Spotted on Debian Testing with GCC 9.2.1:
```
In file included from /otb/Modules/Core/VectorDataBase/include/otbPolyLineParametricPathWithValue.h:34,
from /otb/Modules/Core/VectorDataBase/include/otbPolygon.h:24,
from /otb/Modules/Core/LabelMap/include/otbAttributesMapLabelObject.h:33,
from /otb/Modules/Core/LabelMap/test/otbLabelObjectMapVectorizer.cxx:24:
/otb/Modules/Core/ImageBase/include/otbRemoteSensingRegion.h:118:8: note: because 'otb::RemoteSensingRegion<double>' has user-provided 'void otb::RemoteSensingRegion<TType>::operator=(const Self&) [with TType = double; otb::RemoteSensingRegion<TType>::Self = otb::RemoteSensingRegion<double>]'
118 | void operator=(const Self& region)
| ^~~~~~~~
```
#### Copyright
The copyright owner is Laurențiu Nicola (CS ROMANIA) and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0Laurențiu NicolaLaurențiu Nicolahttps://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/677Fix debian build2020-02-10T11:01:46ZCédric TraizetFix debian build#### Summary
Attempt to fix the debian build
#### Rationale
The bugs come from the upgrade to gdal 3.0.4
This MR add a missing baseline (same projection, different wkt)
I removed the call to GDALDestroy() in the destructor...#### Summary
Attempt to fix the debian build
#### Rationale
The bugs come from the upgrade to gdal 3.0.4
This MR add a missing baseline (same projection, different wkt)
I removed the call to GDALDestroy() in the destructor of GDALDriverManagerWrapper(), calling this method here might be the cause of the crash of `bfTvPolygonizationRasterization_SensorModel`. This is a test. I don't think we should remove the call to GDALDestroy (?), but maybe this is not the place to do it
#### Copyright
The copyright owner is *CNES* and has signed the ORFEO ToolBox Contributor License Agreement.
<hr>
***Check before merging:***
- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit7.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/669CI: Prelimenary conda build2020-02-07T16:35:09Zguillaume pernotCI: Prelimenary conda build7.1.0https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/-/merge_requests/619Some work on BandMathX tests2020-02-07T16:34:53Zguillaume pernotSome work on BandMathX testsAdded "dv" and "pw" testsAdded "dv" and "pw" tests7.1.0