Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 184
    • Issues 184
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !830

Resolve "Implement otb::SarTransformBase, otb::SarForwardTransform and otb::SarInverseTransform"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Osman requested to merge 2151-SAR-in-factory into develop Jul 21, 2021
  • Overview 23
  • Commits 18
  • Pipelines 10
  • Changes 28

Summary

Implement otb::SarTransformBase, otb::SarForwardTransform and otb::SarInverseTransform. Add them to the Sensor Transform Factory.

Rationale

Fix #2151 (closed)

Implementation Details

Classes and files
  • Implement otb::SarTransformBase, otb::SarForwardTransform and otb::SarInverseTransform with the same patern used for otb::RPCTransformBase, otb::RPCForwardTransform and otb::RPCInverseTransform
  • Implement factories for them in otbTransformFactories.h
  • Add the new factories to otb::SensorTransformFactory
Tests
  • Generate new GCPs (for Sentinel1, CosmoSkyNet, TerrasarX and RadarSat2), using OTB7.3 and OSSIM.
  • Use this GCP to test forward and inverse transform, as well as GenericRSTransform
Documentation

Update the page Sensor Model with the SAR sensor model.

Acceptance criterions

  • The new classes are correctly tested with there respective unitary tests.
  • The documentation is up to date.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited Aug 12, 2021 by Julien Osman
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 2151-SAR-in-factory