Skip to content

ExtractROI: Test inverted extent on indices instead of physical coordinates

Julien Osman requested to merge 2208-inverted-ULY-LRY-in-ExtractROI into release-7.4

Summary

Fix #2208 (closed)

Rationale

ExtractROI with the extent mode tests the input coordinates to check that the Upper Left point and the Lower Right point are well positioned. When the user provides physical coordinates (option -mode.extent.unit phy), the position can vary, depending on the projection system. This MR proposes to first convert the coordinates from physical to index, then test the positions.

Implementation Details

Applications
  • otbExtractROI.cpp: move the test after the coordinates conversion.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited by Cédric Traizet

Merge request reports