1. 16 Jun, 2016 1 commit
    • Manuel Grizonnet's avatar
      STYLE: Use ITK_NULLPTR to utilize c++11 features · 0f26e689
      Manuel Grizonnet authored
          Where available, use c++11 features to identify
          potential nullptr usage errors.
      
          python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-nullptr -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Modules/*/*/app/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-nullptr-log.txt
      
          find . -type f -print -name "*.h" -o -name "*.txx" -o -name "*.cxx" |xargs perl -pi -e 's/nullptr/ITK_NULLPTR/g'
      0f26e689
  2. 13 Jun, 2016 1 commit
    • Manuel Grizonnet's avatar
      ENH: Remove double underscore in header guards (.txx & __otb*_h form) · 82842d15
      Manuel Grizonnet authored
      Used the following command:
      
      find . \( -iname *.txx -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_txx/otb$1_txx/g;' {} \;
      find . \( -iname *.h -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_h/otb$1_h/g;' {} \;
      
      Fixes many, but not all, clang -Wreserved-id-macro warnings.
      82842d15
  3. 10 Jun, 2016 1 commit
    • Manuel Grizonnet's avatar
      ENH: Explicitly recognize virtual functions · 3de2b346
      Manuel Grizonnet authored
          clang-tidy tool can insert missing override keyword as a macro so that missing [optional] virtual identifiers can be easily added.
      
          build otb with clang 3.8 and use cmake option CMAKE_EXPORT_COMPILE_COMMANDS=ON. Most modules and third parties have been activated.
      
          #Save override occurences in otb code
          cd src/Modules ; grep -nR "override" * > ~/temporary/override_otb.txt
      
          #Run clang modernize check using utility script which allow to process the code in parallel
          python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-override -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-log.txt
      
          #Replace override by ITK macro (to maintain compat with c++98)
          find . -type f -print -name "*.h" -o -name "*.txx" |xargs perl -pi -e 's/\ override/\ ITK_OVERRIDE/g'
      3de2b346
  4. 17 Mar, 2016 1 commit
  5. 04 Jan, 2016 1 commit
    • Rashad Kanavath's avatar
      ENH: apply spelling.patch from DebianGIS · 8cafd175
      Rashad Kanavath authored
      This is a big one without much harm. It fixes incorrect spelling
      and grammer when packaging OTB 5.0.0 and 5.2.0 for Debian.
      Most of these changes are done by developers at DebianGIS.
      For more info, I include the original patch header below.
      Description: Fix some spelling errors to silence lintian
      enabling  to concentrate on the real problem.
      Author: Andreas Tille <tille@debian.org>
      Author: Rashad Kanavath <rashad.kanavath@c-s.fr>
      Author: Bas Couwenberg <sebastic@xs4all.nl>
      Last-Update: 2015-12-22
      8cafd175
  6. 19 Nov, 2015 1 commit
  7. 25 Feb, 2015 1 commit
  8. 23 Feb, 2015 2 commits
  9. 24 Feb, 2015 1 commit
  10. 18 Feb, 2015 3 commits