1. 16 Nov, 2018 1 commit
  2. 07 Sep, 2018 1 commit
  3. 18 Jul, 2018 1 commit
    • Victor Poughon's avatar
      REFAC: remove unnecessary calls to c_str · ee124eea
      Victor Poughon authored
      This was done with this script:
      
          #!/bin/bash
      
          set -eou pipefail
      
          # Use C++11 sstream constructor from string
          # Exclude 'ThirdParty' because it uses ossimFilename type
          find Modules/ Examples/ -not -iwholename "*ThirdParty*" -type f -print0 | xargs -0 sed -i -E "s/std::ifstream (.*)\((.*)\.c_str\(\)/std::ifstream \1\(\2/"
          find Modules/ Examples/ -not -iwholename "*ThirdParty*" -type f -print0 | xargs -0 sed -i -E "s/std::ofstream (.*)\((.*)\.c_str\(\)/std::ofstream \1\(\2/"
      
          # Use C++11 ::open(const std::string&) of ifstream, ofstream, etc.
          # Exclude ThirdParty because of ossimFilename type
          find Modules/ Examples/ -not -iwholename "*ThirdParty*" -type f -print0 | xargs -0 sed -i -E "s/\.open\((.*).c_str\(\)/\.open\(\1/"
      
          # No need for c_str when outputing to std::cout and such
          find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/\.c_str\(\) ?<</ <</"
      
          # Use itk::ExceptionObject::SetDescription and SetLocation string versions
          find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/e\.SetDescription\((.*)\.c_str\(\)\)/e\.SetDescription\(\1\)/"
          find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/e\.SetLocation\((.*)\.c_str\(\)\)/e\.SetLocation\(\1\)/"
      
          # Use itksys::SystemTool:: string versions
          find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/itksys::SystemTools::(.*)\((.*)\.c_str\(\)/itksys::SystemTools::\1\(\2/"
          # Exclude otbLogger because it uses GetCurrentDateTime which does not have a string version
          git checkout --  Modules/Core/Common/src/otbLogger.cxx
          # Exclude test/otbOGRLayerStreamStitchingFilter.cxx because there's a double use which is not compatible with the regex
          git checkout -- Modules/Segmentation/OGRProcessing/test/otbOGRLayerStreamStitchingFilter.cxx
      ee124eea
  4. 25 Jun, 2018 2 commits
    • Manuel Grizonnet's avatar
      7fe54ded
    • Manuel Grizonnet's avatar
      ENH: rename files with txx extension to hxx · 3a1fd1fc
      Manuel Grizonnet authored
      OTB followed since the beginning the ITK convention and use .txx extension for all
      template classes. Nevertheless, some development tools do not recognize .txx
      file extension. Other tool like GitHub can't do in-browser syntax highlighting for
      txx files I think.
      
      The root problem is the use of the txx which should be changed to hxx (or hpp).
      
      In 2011, after an in-depth discussion near April 20, 2011 on the
      Insight-Developers mailing list, ITK rename all txx files to hxx (and event
      prevent the push of .txx files with a pre-commit hook). It happens is major release v4.
      
      You can find some arguments in the discussion about the change and also in other
      projects related to ITK which applied the same modification, see for instance VXL:
      
      https://github.com/vxl/vxl/issues/209
      
      This commit apply now the same modification for OTB.
      
      I understand that it will change some habit for developers and don't bring new
      features but I think that in general it is better to stay align with ITK guidelines.
      
      In my opinion, it always facilitate the use of OTB and ITK together if we share
      when we can the same code architecture, directory organization, naming
      conventions...
      3a1fd1fc
  5. 07 Jun, 2018 1 commit
  6. 08 Mar, 2017 2 commits
  7. 16 Jun, 2016 1 commit
    • Manuel Grizonnet's avatar
      STYLE: Use ITK_NULLPTR to utilize c++11 features · 0f26e689
      Manuel Grizonnet authored
          Where available, use c++11 features to identify
          potential nullptr usage errors.
      
          python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-nullptr -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Modules/*/*/app/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-nullptr-log.txt
      
          find . -type f -print -name "*.h" -o -name "*.txx" -o -name "*.cxx" |xargs perl -pi -e 's/nullptr/ITK_NULLPTR/g'
      0f26e689
  8. 13 Jun, 2016 1 commit
    • Manuel Grizonnet's avatar
      ENH: Remove double underscore in header guards (.txx & __otb*_h form) · 82842d15
      Manuel Grizonnet authored
      Used the following command:
      
      find . \( -iname *.txx -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_txx/otb$1_txx/g;' {} \;
      find . \( -iname *.h -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_h/otb$1_h/g;' {} \;
      
      Fixes many, but not all, clang -Wreserved-id-macro warnings.
      82842d15
  9. 18 Feb, 2015 1 commit
  10. 05 Jun, 2011 1 commit
  11. 09 May, 2011 1 commit
  12. 09 Apr, 2010 1 commit
  13. 22 Jan, 2010 1 commit
  14. 17 Jan, 2010 1 commit
  15. 30 Jan, 2009 1 commit
  16. 27 Jan, 2009 1 commit
  17. 13 Jan, 2009 1 commit
  18. 06 Dec, 2008 1 commit
  19. 23 Oct, 2007 1 commit
  20. 28 Jun, 2007 1 commit
  21. 27 Jun, 2007 3 commits
  22. 07 Dec, 2006 1 commit
  23. 06 Dec, 2006 1 commit
    • Julien Michel's avatar
      - Correction de la gestion des attributs pour les objets de type Vertex :... · 4450cfbe
      Julien Michel authored
      - Correction de la gestion des attributs pour les objets de type Vertex : passage de std::vector<std::string> à std::map<std::string,std::string> qui est plus adapté.
      - Correction des methodes Build et SetVertex pour l'objet RCC8Graph.
      - Création et tests du RCC8GraphFileReader.
      - Test de bout en bout pour les entrées/sorties du RCC8Graph.
      4450cfbe
  24. 05 Dec, 2006 1 commit