1. 18 Jul, 2018 1 commit
    • Victor Poughon's avatar
      COMP: add missing string includes · fc923078
      Victor Poughon authored
      Before this commit, many files are using std::string without including
      <string>. It can work accidentally but causes issues when refactoring,
      especially if using operator <<() which is included implicitly by some
      compilers.
      
      To find guilty header files, I used:
      
          grep -l "^ *std::string" $(grep -L "#include <string>" $(find . -type f -name "*.h"))
      
      which finds all files containing "std::string" at the beginning of a line
      (usually a member or variable declaration), but not "#include <string>".
      And then this script to add the includes (plus some manual ediing):
      
          #!/usr/bin/env python3
      
          import re
          import argparse
      
          def fix_file(filename, header):
      
              with open(filename, "r") as f:
                  content = f.read()
      
              matches = list(re.finditer(r"(#include .*\n)\n", content))
              if len(matches) == 0:
                  print("no include!")
                  sys.exit(-1)
      
              pos = matches[-1].end(1)
              open(filename, "w").write(content[:pos] + "#include <{}>\n".format(header) + content[pos:])
      
          if __name__ == "__main__":
              parser = argparse.ArgumentParser()
              parser.add_argument('--header', type=str, required=True)
              parser.add_argument('files', type=str, nargs='+')
              args = parser.parse_args()
      
              for filename in args.files:
                  fix_file(filename, args.header)
      fc923078
  2. 25 Jun, 2018 1 commit
  3. 07 Jun, 2018 1 commit
  4. 10 May, 2017 1 commit
  5. 08 Mar, 2017 2 commits
  6. 03 Mar, 2017 1 commit
  7. 15 Sep, 2016 1 commit
  8. 26 Jul, 2016 1 commit
  9. 21 Jul, 2016 1 commit
  10. 16 Jun, 2016 1 commit
    • Manuel Grizonnet's avatar
      STYLE: Use ITK_NULLPTR to utilize c++11 features · 0f26e689
      Manuel Grizonnet authored
          Where available, use c++11 features to identify
          potential nullptr usage errors.
      
          python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-nullptr -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Modules/*/*/app/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-nullptr-log.txt
      
          find . -type f -print -name "*.h" -o -name "*.txx" -o -name "*.cxx" |xargs perl -pi -e 's/nullptr/ITK_NULLPTR/g'
      0f26e689
  11. 13 Jun, 2016 1 commit
    • Manuel Grizonnet's avatar
      ENH: Remove double underscore in header guards (.txx & __otb*_h form) · 82842d15
      Manuel Grizonnet authored
      Used the following command:
      
      find . \( -iname *.txx -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_txx/otb$1_txx/g;' {} \;
      find . \( -iname *.h -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_h/otb$1_h/g;' {} \;
      
      Fixes many, but not all, clang -Wreserved-id-macro warnings.
      82842d15
  12. 15 Apr, 2016 1 commit
  13. 04 Jan, 2016 1 commit
    • Rashad Kanavath's avatar
      ENH: apply spelling.patch from DebianGIS · 8cafd175
      Rashad Kanavath authored
      This is a big one without much harm. It fixes incorrect spelling
      and grammer when packaging OTB 5.0.0 and 5.2.0 for Debian.
      Most of these changes are done by developers at DebianGIS.
      For more info, I include the original patch header below.
      Description: Fix some spelling errors to silence lintian
      enabling  to concentrate on the real problem.
      Author: Andreas Tille <tille@debian.org>
      Author: Rashad Kanavath <rashad.kanavath@c-s.fr>
      Author: Bas Couwenberg <sebastic@xs4all.nl>
      Last-Update: 2015-12-22
      8cafd175
  14. 04 Dec, 2015 1 commit
  15. 12 Oct, 2015 1 commit
  16. 30 Sep, 2015 1 commit
  17. 25 Sep, 2015 1 commit
  18. 01 Apr, 2015 1 commit
  19. 18 Feb, 2015 2 commits
  20. 29 Sep, 2012 2 commits
  21. 22 Jun, 2012 1 commit
  22. 20 Jun, 2012 1 commit
  23. 19 Jun, 2012 3 commits
  24. 14 Jun, 2012 1 commit
  25. 08 Jun, 2012 2 commits
  26. 06 Jun, 2012 1 commit
  27. 09 May, 2012 1 commit
  28. 07 May, 2012 2 commits
  29. 04 May, 2012 1 commit
  30. 03 May, 2012 1 commit
  31. 26 Apr, 2012 1 commit
  32. 25 Apr, 2012 2 commits