1. 25 Jun, 2018 2 commits
    • Manuel Grizonnet's avatar
      7fe54ded
    • Manuel Grizonnet's avatar
      ENH: rename files with txx extension to hxx · 3a1fd1fc
      Manuel Grizonnet authored
      OTB followed since the beginning the ITK convention and use .txx extension for all
      template classes. Nevertheless, some development tools do not recognize .txx
      file extension. Other tool like GitHub can't do in-browser syntax highlighting for
      txx files I think.
      
      The root problem is the use of the txx which should be changed to hxx (or hpp).
      
      In 2011, after an in-depth discussion near April 20, 2011 on the
      Insight-Developers mailing list, ITK rename all txx files to hxx (and event
      prevent the push of .txx files with a pre-commit hook). It happens is major release v4.
      
      You can find some arguments in the discussion about the change and also in other
      projects related to ITK which applied the same modification, see for instance VXL:
      
      https://github.com/vxl/vxl/issues/209
      
      This commit apply now the same modification for OTB.
      
      I understand that it will change some habit for developers and don't bring new
      features but I think that in general it is better to stay align with ITK guidelines.
      
      In my opinion, it always facilitate the use of OTB and ITK together if we share
      when we can the same code architecture, directory organization, naming
      conventions...
      3a1fd1fc
  2. 27 Apr, 2018 1 commit
  3. 12 Mar, 2018 1 commit
  4. 08 Mar, 2017 2 commits
  5. 02 Mar, 2017 1 commit
  6. 01 Aug, 2016 1 commit
  7. 13 Jun, 2016 1 commit
    • Manuel Grizonnet's avatar
      ENH: Remove double underscore in header guards (.txx & __otb*_h form) · 82842d15
      Manuel Grizonnet authored
      Used the following command:
      
      find . \( -iname *.txx -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_txx/otb$1_txx/g;' {} \;
      find . \( -iname *.h -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_h/otb$1_h/g;' {} \;
      
      Fixes many, but not all, clang -Wreserved-id-macro warnings.
      82842d15
  8. 10 Jun, 2016 1 commit
    • Manuel Grizonnet's avatar
      ENH: Explicitly recognize virtual functions · 3de2b346
      Manuel Grizonnet authored
          clang-tidy tool can insert missing override keyword as a macro so that missing [optional] virtual identifiers can be easily added.
      
          build otb with clang 3.8 and use cmake option CMAKE_EXPORT_COMPILE_COMMANDS=ON. Most modules and third parties have been activated.
      
          #Save override occurences in otb code
          cd src/Modules ; grep -nR "override" * > ~/temporary/override_otb.txt
      
          #Run clang modernize check using utility script which allow to process the code in parallel
          python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-override -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-log.txt
      
          #Replace override by ITK macro (to maintain compat with c++98)
          find . -type f -print -name "*.h" -o -name "*.txx" |xargs perl -pi -e 's/\ override/\ ITK_OVERRIDE/g'
      3de2b346
  9. 13 Apr, 2016 1 commit
  10. 04 Dec, 2015 1 commit
  11. 20 Nov, 2015 1 commit
  12. 03 Nov, 2015 1 commit
  13. 01 Apr, 2015 1 commit
  14. 23 Feb, 2015 1 commit
  15. 18 Feb, 2015 1 commit
  16. 04 Oct, 2013 1 commit
  17. 03 Oct, 2013 1 commit
  18. 20 Jun, 2012 1 commit
  19. 07 Jun, 2012 1 commit
  20. 31 May, 2012 1 commit
  21. 29 May, 2012 1 commit
  22. 24 May, 2012 1 commit
  23. 23 May, 2012 1 commit
  24. 21 May, 2012 3 commits
  25. 10 May, 2012 2 commits
  26. 09 May, 2012 1 commit
  27. 07 May, 2012 2 commits
  28. 04 May, 2012 3 commits
  29. 03 May, 2012 2 commits
  30. 27 Apr, 2012 1 commit
  31. 26 Apr, 2012 1 commit