Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
otb
otb
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 189
    • Issues 189
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 13
    • Merge Requests 13
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Main Repositories
  • otbotb
  • Issues
  • #1737

Closed
Open
Opened Oct 05, 2018 by Antoine Regimbeau@aregimbeau
  • Report abuse
  • New issue
Report abuse New issue

VectorImageFilter and ImageFilter fusion

What changes will be made and why they would make a better Orfeo ToolBox?

In OTB we have a lot of filter that can be used on image or vector image. Those filters have the same purpose but not the same name and sometimes not event the same convention.
What can be done is using template meta-prgramming to try to unify those filters (as for the ClampImageFilter using the convert type functor) hence decreasing the number of class to maintain.

High level description

The following filters can be merged :

  • ShiftScaleVectorImageFilter & ShiftScaleImageAdaptor (Warning : not the same convention)
  • StreamingStatisticsVectorImageFilter & StreamingStatisticsImageFilter (related filter : VectorImageToMatrixImageFilter, StreamingMinMaxVectorImageFilter, StreamingMinMaxImageFilter )
  • ExtractROI & MultiChannelExtractROI & MultiToMonoChannelExtractROI

The idea is to make it transparent for coders : FilterType<ImageType> and FilterType<VectorImageType> will have the same behavior and functionnality but will adapt depending on the template parameter.

Risks and benefits

No particular risks.
Benefits : less classes to maintain, less copied/pasted classes, less bugs (hopefully...)!

Edited Oct 05, 2018 by Antoine Regimbeau
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
No due date
0
Labels
None
Assign labels
  • View project labels
Reference: orfeotoolbox/otb#1737