Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
otb
otb
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 189
    • Issues 189
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 13
    • Merge Requests 13
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Main Repositories
  • otbotb
  • Merge Requests
  • !295

Merged
Opened Nov 16, 2018 by Manuel Grizonnet@mgrizonnet
  • Report abuse
Report abuse

Update deprecated cmake policies to NEW

Summary

Update cmake policies in OTB which are deprecated since cmake 3.0 and 3.1.

The branch contains also minor warnings fixes for gcc 8.1.

Let's see how it looks on the dashboard.

Rationale

cmake warnings:

https://dash.orfeo-toolbox.org/viewConfigure.php?buildid=342319

CMake Deprecation Warning at CMakeLists.txt:36 (cmake_policy):
  The OLD behavior for policy CMP0046 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.


CMake Deprecation Warning at CMakeLists.txt:42 (cmake_policy):
  The OLD behavior for policy CMP0054 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.

gcc warnings (this MR did not fix warnings related to openmpi):

https://dash.orfeo-toolbox.org/viewBuildError.php?type=1&buildid=342319

Implementation Details

Additional notes

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Edited Nov 21, 2018 by Manuel Grizonnet
  • Discussion 5
  • Commits 3
  • Changes 6
Manuel Grizonnet
Assignee
Manuel Grizonnet @mgrizonnet
Assign to
7.0.0
Milestone
7.0.0
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: orfeotoolbox/otb!295

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.