Skip to content

Revert "Merge branch 'bugfix-streamingwarpfilter-empty-region' into 'develop'"

Julien Michel requested to merge revert-93111e34 into develop

Summary

This reverts merge request !557 (merged)

Rationale

MR !557 (merged) fixes a bug but breaks streaming for pipelines including a StreamingWarpImageFilter in certain situations: since with this patch the filter does not set any requested region at all, if the previous requested region was set to largest possible region for some reasons, then pipeline update will load full input in memory.

We need to find another patch for this bug.

CI did not show the problem, which I believe is because we only use small data that fit in memory to test this filter.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

Merge request reports