From 81a2ce81cb8e7b22f3cfc9363445ab2499108e7d Mon Sep 17 00:00:00 2001
From: Guillaume Pasero <guillaume.pasero@c-s.fr>
Date: Fri, 12 Jul 2019 10:49:46 +0200
Subject: [PATCH] WRG: various warning fixes
---
include/otbSARDopplerCentroidFreqImageFilter.txx | 4 ++--
include/otbSARESDOffsetsImageFilter.txx | 3 ---
include/otbTilesAnalysisImageFilter.h | 2 +-
include/otbTilesExampleFunctor.h | 2 +-
test/otbSARDopplerCentroidFreqImageFilterTest.cxx | 1 -
5 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/include/otbSARDopplerCentroidFreqImageFilter.txx b/include/otbSARDopplerCentroidFreqImageFilter.txx
index 593e81b..a401dfb 100644
--- a/include/otbSARDopplerCentroidFreqImageFilter.txx
+++ b/include/otbSARDopplerCentroidFreqImageFilter.txx
@@ -90,7 +90,7 @@ namespace otb
for (std::size_t listId=0; listId!= nbLists ; ++listId)
{
- const int pos = sprintf(fmRatePrefix_, "%s%d.", FM_PREFIX.c_str(), (listId+1));
+ const int pos = sprintf(fmRatePrefix_, "%s%zu.", FM_PREFIX.c_str(), (listId+1));
assert(pos > 0 && pos < sizeof(fmRatePrefix_));
const std::string FMPrefix(fmRatePrefix_, pos);
@@ -120,7 +120,7 @@ namespace otb
for (std::size_t listId=0; listId!= nbLists ; ++listId)
{
- const int pos = sprintf(dcfPrefix_, "%s%d.", DCF_PREFIX.c_str(), (listId+1));
+ const int pos = sprintf(dcfPrefix_, "%s%zu.", DCF_PREFIX.c_str(), (listId+1));
assert(pos > 0 && pos < sizeof(dcfPrefix_));
const std::string DCFPrefix(dcfPrefix_, pos);
diff --git a/include/otbSARESDOffsetsImageFilter.txx b/include/otbSARESDOffsetsImageFilter.txx
index 90dbcab..fc47727 100644
--- a/include/otbSARESDOffsetsImageFilter.txx
+++ b/include/otbSARESDOffsetsImageFilter.txx
@@ -184,9 +184,6 @@ namespace otb
// For each colunm
while (!OutIt.IsAtEndOfLine() && !In1It.IsAtEndOfLine() && !In2It.IsAtEndOfLine())
{
- // Output index
- ImageIndexType index = OutIt.GetIndex();
-
double diff_DopCentroid = In1It.Get() - In2It.Get();
// Shift for azimut dimension
diff --git a/include/otbTilesAnalysisImageFilter.h b/include/otbTilesAnalysisImageFilter.h
index 544a6ee..e9bcd34 100644
--- a/include/otbTilesAnalysisImageFilter.h
+++ b/include/otbTilesAnalysisImageFilter.h
@@ -190,7 +190,7 @@ protected:
first tile */
virtual void ThreadedGenerateData(unsigned int startTileId, unsigned int stopTileId,
unsigned int firstTileIndexL, unsigned int firstTileIndexC,
- itk::ThreadIdType threadId);
+ itk::ThreadIdType threadId) ITK_OVERRIDE;
/** Static function used as a "callback" by the MultiThreader. The threading
* library will call this routine for each thread, which will delegate the
diff --git a/include/otbTilesExampleFunctor.h b/include/otbTilesExampleFunctor.h
index 4c9f7fe..a7d9f47 100644
--- a/include/otbTilesExampleFunctor.h
+++ b/include/otbTilesExampleFunctor.h
@@ -111,7 +111,7 @@ public:
// Process
void Process(ImageInPointer inputPtr, ImageOutRegionType outputRegion, ImageOutPixelType * TilesResult,
- int threadId=0)
+ int /*threadId=0*/)
{
// Transpose outputRegion (current tile) into input image
// Input (= output now)
diff --git a/test/otbSARDopplerCentroidFreqImageFilterTest.cxx b/test/otbSARDopplerCentroidFreqImageFilterTest.cxx
index a983cdd..be6d908 100644
--- a/test/otbSARDopplerCentroidFreqImageFilterTest.cxx
+++ b/test/otbSARDopplerCentroidFreqImageFilterTest.cxx
@@ -39,7 +39,6 @@ int otbSARDopplerCentroidFreqFilterTest(int argc, char * argv[])
// Image type
const unsigned int Dimension = 2;
- typedef otb::Image <std::complex<float>, 2> ImageSARInType ;
typedef otb::Image <float, 2> FloatImageType;
typedef otb::VectorImage<float> FloatVectorImageType;
--
GitLab