Adapt S1TIling to OTB 8.0

added Enhancements label

assigned to @lhermitte

changed the description

created merge request !65 (merged) to address this issue

mentioned in merge request !65 (merged)

marked the checklist item RAM parameter is now expected as an integer as completed

changed the description

@lhermitte orfeotoolbox/otb#2307 must be solved. Otherwise it will not work.

OTB 8+ is rejecting the GEOID file

(WARNING): input geoid file /home/luc/dev/S1tiling/s1tiling/s1tiling/resources/Geoid/egm96.grd will not be used because it has no input projection.

~~We may need another reference file.~~

EDIT; Can be fixed by patching egm96.grd. See

S1Tiling won't be able to support OTB 8.0. The minimal required version is OTB 8.1.1

added ready-to-be-tested label

Test failed with OTB 8.1.1

ERROR - Execution of PrepareForOrtho -> /tmp/pbs.42972849.admin01/s1tiling/S1/s1a-iw-grd-vh-20230419t041802-20230419t041827-048160-05ca4f-002_gamma_OrthoReady.tiff from ['/tmp/pbs.42972849.admin01/s1tiling/raw/S1A_IW_GRDH_1SDV_20230419T041802_20230419T041827_048160_05CA4F_B16F/S1A_IW_GRDH_1SDV_20230419T041802_20230419T041827_048160_05CA4F_B16F.SAFE/measurement/s1a-iw-grd-vh-20230419t041802-20230419t041827-048160-05ca4f-002.tiff'] failed
Traceback (most recent call last):
  File "/softs/projets/otb/rh7/8.1-python3.8.4/depends/lib/python3.8/site-packages/osgeo/gdal_array.py", line 14, in swig_import_helper
    return importlib.import_module(mname)
  File "/home/il/koleckt/.conda/envs/s1tiling-dev/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 657, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 556, in module_from_spec
  File "<frozen importlib._bootstrap_external>", line 1101, in create_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
ImportError: /softs/projets/otb/rh7/8.1-python3.8.4/depends/lib/python3.8/site-packages/osgeo/_gdal_array.cpython-38-x86_64-linux-gnu.so: undefined symbol: _ZNK11GDALDataset14GetFieldDomainERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/il/koleckt/s1tiling-dev/s1tiling/s1tiling/libs/otbpipeline.py", line 948, in execute4dask
    res = pipeline.do_execute().add_related_filename(pipeline.output)
  File "/home/il/koleckt/s1tiling-dev/s1tiling/s1tiling/libs/otbpipeline.py", line 914, in do_execute
    step = crt.create_step(self.__in_memory, steps)
  File "/home/il/koleckt/s1tiling-dev/s1tiling/s1tiling/libs/otbpipeline.py", line 779, in create_step
    meta   = self.complete_meta(inp.meta, inputs)
  File "/home/il/koleckt/s1tiling-dev/s1tiling/s1tiling/libs/otbwrappers.py", line 261, in complete_meta
    north = ds_reader.ReadAsArray(0, 100, xsize, 1)
  File "/softs/projets/otb/rh7/8.1-python3.8.4/depends/lib/python3.8/site-packages/osgeo/gdal.py", line 2560, in ReadAsArray
    from osgeo import gdal_array
  File "/softs/projets/otb/rh7/8.1-python3.8.4/depends/lib/python3.8/site-packages/osgeo/gdal_array.py", line 17, in <module>
    _gdal_array = swig_import_helper()
  File "/softs/projets/otb/rh7/8.1-python3.8.4/depends/lib/python3.8/site-packages/osgeo/gdal_array.py", line 16, in swig_import_helper
    return importlib.import_module('_gdal_array')
  File "/home/il/koleckt/.conda/envs/s1tiling-dev/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
ModuleNotFoundError: No module named '_gdal_array'

This import error is typical of an incorrect installation of GDAL bindings.

I remember I always have to follow a strict procedure to make sure everything is correctly installed (see the Dockerfile/documentation). It could also come from the new GDAL version that OTB 8.1+ uses -- in case you were reusing a previous virtual environment.

changed the description

marked the checklist item (Im)Port SARDEMProjection into NORMLIM_sigma0 as completed

changed milestone to %1.1

mentioned in commit abdfaab8

closed with merge request !65 (merged)

Adapt S1TIling to OTB 8.0

Designs

Child items ...

Activity