From 0f874ef72be38b5129635f5cd37dbcb7ad17a67d Mon Sep 17 00:00:00 2001
From: Julien Michel <julien.michel@orfeo-toolbox.org>
Date: Mon, 9 Feb 2015 17:35:48 +0100
Subject: [PATCH] COV: Fixing coverity issues in QtWidget
---
.../QtWidget/otbWrapperQtWidgetProgressReport.cxx | 14 +++++++++-----
.../otbWrapperQtWidgetSimpleProgressReport.cxx | 14 +++++++++-----
2 files changed, 18 insertions(+), 10 deletions(-)
diff --git a/Code/Wrappers/QtWidget/otbWrapperQtWidgetProgressReport.cxx b/Code/Wrappers/QtWidget/otbWrapperQtWidgetProgressReport.cxx
index 2fff9e1540..691443ccbb 100644
--- a/Code/Wrappers/QtWidget/otbWrapperQtWidgetProgressReport.cxx
+++ b/Code/Wrappers/QtWidget/otbWrapperQtWidgetProgressReport.cxx
@@ -28,6 +28,7 @@ namespace Wrapper
{
QtWidgetProgressReport::QtWidgetProgressReport(QtWidgetModel * model)
+ : m_CurrentProcess()
{
m_Model = model;
connect(model, SIGNAL(SetProgressReportBegin()), this, SLOT(show()) );
@@ -61,11 +62,14 @@ QtWidgetProgressReport::ProcessEvent( itk::Object * itkNotUsed(caller),
{
if( typeid( otb::Wrapper::AddProcessToWatchEvent ) == typeid( event ) )
{
- const AddProcessToWatchEvent* eventToWacth = dynamic_cast< const AddProcessToWatchEvent*> ( &event );
-
- m_CurrentProcess = eventToWacth->GetProcess();
- m_CurrentDescription = eventToWacth->GetProcessDescription();
- emit AddNewProcessToReport();
+ const AddProcessToWatchEvent* eventToWatch = dynamic_cast< const AddProcessToWatchEvent*> ( &event );
+
+ if(eventToWatch)
+ {
+ m_CurrentProcess = eventToWatch->GetProcess();
+ m_CurrentDescription = eventToWatch->GetProcessDescription();
+ emit AddNewProcessToReport();
+ }
}
}
diff --git a/Code/Wrappers/QtWidget/otbWrapperQtWidgetSimpleProgressReport.cxx b/Code/Wrappers/QtWidget/otbWrapperQtWidgetSimpleProgressReport.cxx
index 3394487685..5809ed799e 100644
--- a/Code/Wrappers/QtWidget/otbWrapperQtWidgetSimpleProgressReport.cxx
+++ b/Code/Wrappers/QtWidget/otbWrapperQtWidgetSimpleProgressReport.cxx
@@ -28,6 +28,7 @@ namespace Wrapper
{
QtWidgetSimpleProgressReport::QtWidgetSimpleProgressReport(QtWidgetModel * model)
+ : m_CurrentProcess()
{
m_Model = model;
connect(model, SIGNAL(SetProgressReportBegin()), this, SLOT(show()) );
@@ -68,11 +69,14 @@ QtWidgetSimpleProgressReport::ProcessEvent( itk::Object * itkNotUsed(caller),
{
if( typeid( otb::Wrapper::AddProcessToWatchEvent ) == typeid( event ) )
{
- const AddProcessToWatchEvent* eventToWacth = dynamic_cast< const AddProcessToWatchEvent*> ( &event );
-
- m_CurrentProcess = eventToWacth->GetProcess();
- m_CurrentDescription = eventToWacth->GetProcessDescription();
- emit AddNewProcessToReport();
+ const AddProcessToWatchEvent* eventToWatch = dynamic_cast< const AddProcessToWatchEvent*> ( &event );
+
+ if(eventToWatch)
+ {
+ m_CurrentProcess = eventToWatch->GetProcess();
+ m_CurrentDescription = eventToWatch->GetProcessDescription();
+ emit AddNewProcessToReport();
+ }
}
}
--
GitLab