diff --git a/Modules/Adapters/GdalAdapters/include/otbOGRVersionProxy.h b/Modules/Adapters/GdalAdapters/include/otbOGRVersionProxy.h index 084feff4fec82d3678be27e91a6dc11ba30f6c7c..ec1e158e242ee06f6cb855c2353bdb732171fb06 100644 --- a/Modules/Adapters/GdalAdapters/include/otbOGRVersionProxy.h +++ b/Modules/Adapters/GdalAdapters/include/otbOGRVersionProxy.h @@ -48,12 +48,6 @@ namespace ogr namespace version_proxy { -/** -* With Gdal >= 2.0, this function will test equality between type and -* OFTInteger64 enum. Otherwise, it returns false. -*/ -OTBGdalAdapters_EXPORT bool IsOFTInteger64(OGRFieldType type); - /** * This namespace holds proxy functions hiding interface changes in gdal 2.0 * diff --git a/Modules/Adapters/GdalAdapters/src/otbOGRVersionProxy.cxx b/Modules/Adapters/GdalAdapters/src/otbOGRVersionProxy.cxx index b616fe752698e68c3731b5ef6bf822802468a33c..186c09cc5dd035e38833ff213282df99d40812a9 100644 --- a/Modules/Adapters/GdalAdapters/src/otbOGRVersionProxy.cxx +++ b/Modules/Adapters/GdalAdapters/src/otbOGRVersionProxy.cxx @@ -49,18 +49,6 @@ namespace ogr namespace version_proxy { -/*-------------------------[GDAL v2 API change]-------------------------------*/ -OTBGdalAdapters_EXPORT bool IsOFTInteger64(OGRFieldType type) -{ -#if GDAL_VERSION_NUM<2000000 - (void)type; - return false; -#else - return type == OFTInteger64; -#endif -} - - GDALDatasetType * Open(const char * filename, bool readOnly , std::vector< std::string > const & options ) { #if GDAL_VERSION_NUM<2000000 diff --git a/Modules/Applications/AppClassification/app/otbComputeConfusionMatrix.cxx b/Modules/Applications/AppClassification/app/otbComputeConfusionMatrix.cxx index da9a2e3c48c9d2f36d40fdca08f05bcb26dd27f5..f2a87a11617a8d47812153f7285047b133eb7094 100644 --- a/Modules/Applications/AppClassification/app/otbComputeConfusionMatrix.cxx +++ b/Modules/Applications/AppClassification/app/otbComputeConfusionMatrix.cxx @@ -204,7 +204,7 @@ private: OGRFieldType fieldType = feature.ogr().GetFieldDefnRef(iField)->GetType(); - if(fieldType == OFTString || fieldType == OFTInteger || ogr::version_proxy::IsOFTInteger64(fieldType)) + if(fieldType == OFTString || fieldType == OFTInteger || fieldType == OFTInteger64) { std::string tmpKey="ref.vector.field."+key.substr(0, end - key.begin()); AddChoice(tmpKey,item); diff --git a/Modules/Applications/AppClassification/app/otbPolygonClassStatistics.cxx b/Modules/Applications/AppClassification/app/otbPolygonClassStatistics.cxx index 751cba5c08ad7c1b8f590d69fc256fd16ae3f5c9..92d159b8b3341132564b52664be90b8cf16bf7aa 100644 --- a/Modules/Applications/AppClassification/app/otbPolygonClassStatistics.cxx +++ b/Modules/Applications/AppClassification/app/otbPolygonClassStatistics.cxx @@ -148,7 +148,7 @@ private: OGRFieldType fieldType = feature.ogr().GetFieldDefnRef(iField)->GetType(); - if(fieldType == OFTString || fieldType == OFTInteger || ogr::version_proxy::IsOFTInteger64(fieldType)) + if(fieldType == OFTString || fieldType == OFTInteger || fieldType == OFTInteger64) { std::string tmpKey="field."+key.substr(0, end - key.begin()); AddChoice(tmpKey,item); diff --git a/Modules/Applications/AppClassification/app/otbSampleAugmentation.cxx b/Modules/Applications/AppClassification/app/otbSampleAugmentation.cxx index a9fbff3aa10f57bea7c6e5641bfe704a50b16690..6446b4f434a4aa82ee7e05e11dc81d3905cbbfd3 100644 --- a/Modules/Applications/AppClassification/app/otbSampleAugmentation.cxx +++ b/Modules/Applications/AppClassification/app/otbSampleAugmentation.cxx @@ -168,7 +168,7 @@ private: OGRFieldType fieldType = feature.ogr().GetFieldDefnRef(iField)->GetType(); - if(fieldType == OFTString || fieldType == OFTInteger || ogr::version_proxy::IsOFTInteger64(fieldType)) + if(fieldType == OFTString || fieldType == OFTInteger || fieldType == OFTInteger64) { std::string tmpKey="field."+key.substr(0, end - key.begin()); AddChoice(tmpKey,item); diff --git a/Modules/Applications/AppClassification/app/otbSampleExtraction.cxx b/Modules/Applications/AppClassification/app/otbSampleExtraction.cxx index 2c48308344b02b27744c3c362a07603ceb348c47..9a0741d46cbc81ed060d9d8a06d3dad85a32a6c9 100644 --- a/Modules/Applications/AppClassification/app/otbSampleExtraction.cxx +++ b/Modules/Applications/AppClassification/app/otbSampleExtraction.cxx @@ -140,7 +140,7 @@ private: OGRFieldType fieldType = feature.ogr().GetFieldDefnRef(iField)->GetType(); - if(fieldType == OFTString || fieldType == OFTInteger || ogr::version_proxy::IsOFTInteger64(fieldType)) + if(fieldType == OFTString || fieldType == OFTInteger || fieldType == OFTInteger64) { std::string tmpKey="field."+key.substr(0, end - key.begin()); AddChoice(tmpKey,item); diff --git a/Modules/Applications/AppClassification/app/otbSampleSelection.cxx b/Modules/Applications/AppClassification/app/otbSampleSelection.cxx index 93af2fc2d6571aff369be6f439b92640f7b8b4aa..b0a807425b0807711611909b5362a36292558912 100644 --- a/Modules/Applications/AppClassification/app/otbSampleSelection.cxx +++ b/Modules/Applications/AppClassification/app/otbSampleSelection.cxx @@ -248,7 +248,7 @@ private: OGRFieldType fieldType = feature.ogr().GetFieldDefnRef(iField)->GetType(); - if(fieldType == OFTString || fieldType == OFTInteger || ogr::version_proxy::IsOFTInteger64(fieldType)) + if(fieldType == OFTString || fieldType == OFTInteger || fieldType == OFTInteger64) { std::string tmpKey="field."+key.substr(0, end - key.begin()); AddChoice(tmpKey,item); diff --git a/Modules/Applications/AppClassification/app/otbVectorClassifier.cxx b/Modules/Applications/AppClassification/app/otbVectorClassifier.cxx index 648b1d465fc5a24ea97791c0a6434c1de05b6ff4..9f0cecea8441570a6e0662258a17c725a41d87d9 100644 --- a/Modules/Applications/AppClassification/app/otbVectorClassifier.cxx +++ b/Modules/Applications/AppClassification/app/otbVectorClassifier.cxx @@ -183,7 +183,7 @@ private: std::transform(key.begin(), key.end(), key.begin(), tolower); OGRFieldType fieldType = layerDefn.GetFieldDefn(iField)->GetType(); - if(fieldType == OFTInteger || ogr::version_proxy::IsOFTInteger64(fieldType) || fieldType == OFTReal) + if(fieldType == OFTInteger || fieldType == OFTInteger64 || fieldType == OFTReal) { std::string tmpKey="feat."+key; AddChoice(tmpKey,item); diff --git a/Modules/Applications/AppClassification/include/otbTrainVectorBase.hxx b/Modules/Applications/AppClassification/include/otbTrainVectorBase.hxx index 482fa32e0f02c1cb8df01fcb74469072a398050e..a87570027ae7ca746b5bbefc0f383335fdb435ef 100644 --- a/Modules/Applications/AppClassification/include/otbTrainVectorBase.hxx +++ b/Modules/Applications/AppClassification/include/otbTrainVectorBase.hxx @@ -131,12 +131,12 @@ void TrainVectorBase::DoUpdateParameters() OGRFieldType fieldType = feature.ogr().GetFieldDefnRef( iField )->GetType(); - if( fieldType == OFTInteger || ogr::version_proxy::IsOFTInteger64( fieldType ) || fieldType == OFTReal ) + if( fieldType == OFTInteger || fieldType == OFTInteger64 || fieldType == OFTReal ) { std::string tmpKey = "feat." + key.substr( 0, static_cast<unsigned long>( end - key.begin() ) ); AddChoice( tmpKey, item ); } - if( fieldType == OFTString || fieldType == OFTInteger || ogr::version_proxy::IsOFTInteger64( fieldType ) ) + if( fieldType == OFTString || fieldType == OFTInteger || fieldType == OFTInteger64 ) { std::string tmpKey = "cfield." + key.substr( 0, static_cast<unsigned long>( end - key.begin() ) ); AddChoice( tmpKey, item ); diff --git a/Modules/Learning/Sampling/src/otbSampleAugmentationFilter.cxx b/Modules/Learning/Sampling/src/otbSampleAugmentationFilter.cxx index 5778de0d9324b7a022cab8569c3b25a48260cfc8..1ff5bb8043539fa4f45dc7c90f0f52535e86f1c3 100644 --- a/Modules/Learning/Sampling/src/otbSampleAugmentationFilter.cxx +++ b/Modules/Learning/Sampling/src/otbSampleAugmentationFilter.cxx @@ -247,7 +247,7 @@ SampleAugmentationFilter { OGRFieldType fieldType = feature.ogr().GetFieldDefnRef(idx)->GetType(); return (fieldType == OFTInteger - || ogr::version_proxy::IsOFTInteger64( fieldType ) + || fieldType == OFTInteger64 || fieldType == OFTReal); }