From 56f33fa2b51abbc33f26f6b23310020f885f5b22 Mon Sep 17 00:00:00 2001
From: Julien Osman <julien.osman@c-s.fr>
Date: Thu, 9 Apr 2020 14:45:09 +0200
Subject: [PATCH] PERF: follow OTB guidlines + optimize a loop

---
 .../test/otbExtendedFilenameToWriterOptionsTest.cxx       | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Modules/IO/ExtendedFilename/test/otbExtendedFilenameToWriterOptionsTest.cxx b/Modules/IO/ExtendedFilename/test/otbExtendedFilenameToWriterOptionsTest.cxx
index e7f61af501..6ad79a8f89 100644
--- a/Modules/IO/ExtendedFilename/test/otbExtendedFilenameToWriterOptionsTest.cxx
+++ b/Modules/IO/ExtendedFilename/test/otbExtendedFilenameToWriterOptionsTest.cxx
@@ -46,17 +46,21 @@ int otbExtendedFilenameToWriterOptions(int itkNotUsed(argc), char* argv[])
 
   file << helper->gdalCreationOptionsIsSet() << std::endl;
   if (helper->gdalCreationOptionsIsSet())
+  {
     for (unsigned int i = 0; i < helper->GetgdalCreationOptions().size(); i++)
     {
       file << helper->GetgdalCreationOptions()[i] << std::endl;
     }
+  }
 
   file << helper->NoDataValueIsSet() << std::endl;
   if (helper->NoDataValueIsSet())
-    for (unsigned int i = 0; i < helper->GetNoDataList().size(); i++)
+  {
+    for (auto const& nodata_kv : helper->GetNoDataList())
     {
-      file << helper->GetNoDataList()[i].first << " ; " << helper->GetNoDataList()[i].second << std::endl;
+      file << nodata_kv.first << " ; " << nodata_kv.second << "\n";
     }
+  }
 
   file << helper->SrsValueIsSet() << std::endl;
   if (helper->SrsValueIsSet())
-- 
GitLab