ENH: Move the new deburst filter to SARCalibration module and remove the SAR...

ENH: Move the new deburst filter to SARCalibration module and remove the SAR module introduced in this RFC (from RFC review)

Modules/Applications/AppSARCalibration/otb-module.cmake

@@ -3,7 +3,6 @@ set(DOCUMENTATION "SAR Calibration application.")
 otb_module(OTBAppSARCalibration 
   DEPENDS
     OTBSARCalibration
-    OTBSAR
     OTBApplicationEngine
   TEST_DEPENDS
     OTBTestKernel

Modules/Filtering/SAR/CMakeLists.txt

-project(OTBSAR)
-otb_module_impl()

Modules/Filtering/SAR/otb-module.cmake

-set(DOCUMENTATION "This module provides basic SAR processing operations.")
-
-otb_module(OTBSAR
-  DEPENDS
-    OTBCommon
-    OTBITK
-    OTBOSSIMAdapters
-  TEST_DEPENDS
-    OTBImageBase
-    OTBImageIO
-    OTBTestKernel
-
-  DESCRIPTION
-    "${DOCUMENTATION}"
-)

Modules/Filtering/SAR/test/CMakeLists.txt

-otb_module_test()
-
-set(OTBSARTests
-  otbSARTestDriver.cxx
-  otbSarDeburstFilterTest.cxx
-  )
-
-add_executable(otbSARTestDriver ${OTBSARTests})
-target_link_libraries(otbSARTestDriver ${OTBSAR-Test_LIBRARIES})
-otb_module_target_label(otbSARTestDriver)
-
-otb_add_test(NAME saTvSarDeburstImageFilterTest COMMAND otbSARTestDriver
-  --compare-image ${NOTOL}
-  ${BASELINE}/saTvSarDeburstImageFilterTestOutput.tif
-  ${TEMP}/saTvSarDeburstImageFilterTestOutput.tif
-  otbSarDeburstFilterTest
-  ${INPUTDATA}/s1a-iw1-slc-vh-amp_xt.tif
-  ${TEMP}/saTvSarDeburstImageFilterTestOutput.tif)

Modules/Filtering/SAR/test/otbSARTestDriver.cxx

-#include "otbTestMain.h"
-void RegisterTests()
-{
-  REGISTER_TEST(otbSarDeburstFilterTest);
-}

Modules/Filtering/SAR/include/otbSarDeburstImageFilter.h → Modules/Radiometry/SARCalibration/include/otbSarDeburstImageFilter.h

@@ -39,7 +39,7 @@ namespace otb
  * 
  * Note that currently only Sentinel1 IW SLC products are supported.
  * 
- * \ingroup OTBSAR
+ * \ingroup OTBSARCalibration
  */
 
 template <class TImage> class ITK_EXPORT SarDeburstImageFilter :

Modules/Radiometry/SARCalibration/test/CMakeLists.txt

@@ -22,6 +22,7 @@ otbSarRadiometricCalibrationFunctionWithoutNoise.cxx
 otbTerraSarBrightnessImageComplexFilterTest.cxx
 otbSarRadiometricCalibrationToImageFilterWithComplexPixelTest.cxx
 otbSarBrightnessToImageFilterTest.cxx
+otbSarDeburstFilterTest.cxx
 )
 
 add_executable(otbSARCalibrationTestDriver ${OTBSARCalibrationTests})
@@ -272,3 +273,11 @@ otb_add_test(NAME raTvSarBrightnessToImageFilter COMMAND  otbSARCalibrationTestD
   ${TEMP}/raTvSarBrightnessToImageFilter_TSX_PANGKALANBUUN_HH.tif
   1000 1000 250 250 # Extract
   )
+
+otb_add_test(NAME saTvSarDeburstImageFilterTest COMMAND otbSARCalibrationTestDriver
+  --compare-image ${NOTOL}
+  ${BASELINE}/saTvSarDeburstImageFilterTestOutput.tif
+  ${TEMP}/saTvSarDeburstImageFilterTestOutput.tif
+  otbSarDeburstFilterTest
+  ${INPUTDATA}/s1a-iw1-slc-vh-amp_xt.tif
+  ${TEMP}/saTvSarDeburstImageFilterTestOutput.tif)

Modules/Radiometry/SARCalibration/test/otbSARCalibrationTestDriver.cxx

@@ -21,4 +21,5 @@ void RegisterTests()
   REGISTER_TEST(otbTerraSarBrightnessImageComplexFilterTest);
   REGISTER_TEST(otbSarRadiometricCalibrationToImageFilterWithComplexPixelTest);
   REGISTER_TEST(otbSarBrightnessToImageFilterTest);
+  REGISTER_TEST(otbSarDeburstFilterTest);
 }