REFAC: take Luc comments into account (2) for OGRExtendedFileName class

Modules/Adapters/GdalAdapters/include/otbOGRExtendedFilenameToOptions.h

@@ -45,7 +45,7 @@ public:
   typedef ExtendedFilenameHelper Superclass;
 
   typedef Superclass::OptionMapType OptionMapType;
-  typedef OptionMapType::iterator MapIteratorType;
+  typedef OptionMapType::const_iterator ConstMapIteratorType;
   typedef std::vector<std::string> GDALOptionType;
 
   itkTypeMacro(OGRExtendedFilenameToOptions, otb::ExtendedFilenameHelper);

Modules/Adapters/GdalAdapters/src/otbOGRExtendedFilenameToOptions.cxx

@@ -56,9 +56,9 @@ SetExtendedFileName(const char *extFname)
   Superclass::SetExtendedFileName(extFname);
   m_HasFileName = true;
 
-  OptionMapType map = GetOptionMap();
+  const OptionMapType & map = GetOptionMap();
 
-  MapIteratorType it;
+  ConstMapIteratorType it;
   for ( it=map.begin(); it != map.end(); it++ )
     {
     std::vector<std::string> tmp;
@@ -144,9 +144,7 @@ bool
 OGRExtendedFilenameToOptions::
 HasGDALLayerOption() const
 {
-  if ( m_LayerOptions.gdalOptions.empty() )
-    return false;
-  return true;
+  return ! m_LayerOptions.gdalOptions.empty() ;
 }
 
 OGRExtendedFilenameToOptions::