WRG: remove unsigned int comparison with <0

Code/OBIA/otbLabelObjectToPolygonFunctor.txx

+
 /*=========================================================================
 
   Program:   ORFEO Toolbox
@@ -337,7 +338,7 @@ LabelObjectToPolygonFunctor<TLabelObject, TPolygon>
   IndexType    resp;
   resp[0] = -1;
 
-  if (line < 0 || line >= m_InternalDataSet.size())
+  if (line >= m_InternalDataSet.size())
     {
     resp[1] = -1;
     return resp;
@@ -403,7 +404,7 @@ LabelObjectToPolygonFunctor<TLabelObject, TPolygon>
   IndexType    resp;
   resp[0] = -1;
 
-  if (line < 0 || line >= m_InternalDataSet.size())
+  if (line >= m_InternalDataSet.size())
     {
     resp[1] = -1;
     return resp;
@@ -439,7 +440,7 @@ LabelObjectToPolygonFunctor<TLabelObject, TPolygon>
   IndexType resp;
   resp[0] = -1;
 
-  if (line < 0 || line >= m_InternalDataSet.size())
+  if (line >= m_InternalDataSet.size())
     {
     resp[1] = -1;
     return resp;

Code/Simulation/otbSpectralResponse.txx

@@ -119,10 +119,8 @@ SpectralResponse<TPrecision, TValuePrecision>
 
   //this test should be always true since
   // lambda<=lambdaMin and lambda>=lambdaMax have been just tested
-  if ((lambdaPosGuess < 0) || (lambdaPosGuess > m_Response.size()))
-    {
-    return 0;
-    }
+  assert(!(lambdaPosGuess < 0) || (lambdaPosGuess > m_Response.size()));
+
   // TODO JGU : test algorithm
   //lambdaPosGuess calculus have been modified (initially lambdaPosGuess = static_cast<unsigned int> ((lambda - lambdaMin) / (lambdaMax - lambdaMin)
   //* m_Response.size() -1). lambdaPosGuess = 0 for lambda contained in  m_Response first bin