ENH: invert bool return philosophy (true if OK)

Code/ApplicationEngine/otbWrapperInputImageListParameter.cxx

@@ -56,7 +56,7 @@ InputImageListParameter::SetListFromFileName(const std::vector<std::string> & fi
         {
         reader->UpdateOutputInformation();
         }
-      catch(itk::ExceptionObject & err)
+      catch(itk::ExceptionObject & /*err*/)
         {
         this->ClearValue();
         isOk = false;

Code/ApplicationEngine/otbWrapperInputImageParameter.cxx

@@ -56,7 +56,7 @@ InputImageParameter::SetFromFileName(const std::string& filename)
       {
       reader->UpdateOutputInformation();
       }
-    catch(itk::ExceptionObject & err)
+    catch(itk::ExceptionObject & /*err*/)
       {
       return false;
       }

Code/ApplicationEngine/otbWrapperInputVectorDataListParameter.cxx

@@ -106,7 +106,7 @@ InputVectorDataListParameter::AddFromFileName(const std::string & filename)
       {
       reader->UpdateOutputInformation();
       }
-    catch(itk::ExceptionObject & err)
+    catch(itk::ExceptionObject & /*err*/)
       {
       return false;
       }

Code/ApplicationEngine/otbWrapperInputVectorDataParameter.cxx

@@ -51,7 +51,7 @@ InputVectorDataParameter::SetFromFileName(const std::string& filename)
       {
       reader->UpdateOutputInformation();
       }
-    catch(itk::ExceptionObject & err)
+    catch(itk::ExceptionObject & /*err*/)
       {
       return false;
       }

Code/Wrappers/QtWidget/otbWrapperQtWidgetInputImageParameter.cxx

@@ -85,7 +85,7 @@ bool QtWidgetInputImageParameter::SetFileName(const QString& value)
 {
   bool res = true;
   // save value
-  if(m_InputImageParam->SetFromFileName(value.toStdString()) == false )
+  if(m_InputImageParam->SetFromFileName(value.toStdString()) == true )
     {
     // notify of value change
     QString key( QString::fromStdString(m_InputImageParam->GetKey()) );

Code/Wrappers/QtWidget/otbWrapperQtWidgetInputVectorDataParameter.cxx

@@ -85,7 +85,7 @@ bool QtWidgetInputVectorDataParameter::SetFileName(const QString& value)
 {
   bool res = true;
   // save value
-  if(m_InputVectorDataParam->SetFromFileName(value.toStdString()) == false )
+  if(m_InputVectorDataParam->SetFromFileName(value.toStdString()) == true )
     {
     // notify of value change
     QString key( QString::fromStdString(m_InputVectorDataParam->GetKey()) );