STYLE: This class should not derive from InPlaceImageFilter, even with InPlaceOff().

Code/ChangeDetection/otbBinaryFunctorNeighborhoodJoinHistogramImageFilter.h

@@ -37,12 +37,12 @@ namespace otb
  */
 template <class TInputImage1, class TInputImage2, 
           class TOutputImage, class TFunction    >
-class ITK_EXPORT BinaryFunctorNeighborhoodJoinHistogramImageFilter : public itk::InPlaceImageFilter<TInputImage1,TOutputImage> 
+class ITK_EXPORT BinaryFunctorNeighborhoodJoinHistogramImageFilter : public itk::ImageToImageFilter<TInputImage1,TOutputImage> 
 {
 public:
   /** Standard class typedefs. */
   typedef BinaryFunctorNeighborhoodJoinHistogramImageFilter  Self;
-  typedef itk::BinaryFunctorImageFilter<TInputImage1,TInputImage2,TOutputImage,TFunction>   Superclass;
+  typedef itk::ImageToImageFilter<TInputImage1,TOutputImage>   Superclass;
   typedef itk::SmartPointer<Self>   Pointer;
   typedef itk::SmartPointer<const Self>  ConstPointer;
 
@@ -50,7 +50,7 @@ public:
   itkNewMacro(Self);
   
   /** Run-time type information (and related methods). */
-  itkTypeMacro(BinaryFunctorNeighborhoodJoinHistogramImageFilter, BinaryFunctorImageFilter);
+  itkTypeMacro(BinaryFunctorNeighborhoodJoinHistogramImageFilter, ImageToImageFilter);
 
 
   /** Some convenient typedefs. */
@@ -68,7 +68,7 @@ public:
   typedef typename OutputImageType::RegionType OutputImageRegionType;
   typedef typename OutputImageType::PixelType OutputImagePixelType;
 
-  typedef itk::ProcessObject ProcessObjectType;
+  typedef itk::ProcessObject ProcessObjectType;
 
   /** Connect one of the operands for pixel-wise addition */
   void SetInput1( const TInputImage1 * image1);

Code/ChangeDetection/otbBinaryFunctorNeighborhoodJoinHistogramImageFilter.txx

@@ -36,7 +36,6 @@ BinaryFunctorNeighborhoodJoinHistogramImageFilter<TInputImage1,TInputImage2,TOut
 ::BinaryFunctorNeighborhoodJoinHistogramImageFilter()
 {
   this->SetNumberOfRequiredInputs( 2 );
-  this->InPlaceOff();
   m_Radius = 3;
   m_HistogramSize.Fill(256);
   m_UsePaddingValue = false;