COMP: small bug fixes

Code/Projections/otbGCPsToRPCSensorModelImageFilter.h

@@ -51,8 +51,8 @@ namespace otb {
  * using the appropriate setter, or configure the existing internal
  * DEMHandler using the Getter.
  *
- * The residual ground error is available through the appropriate
- * getter.
+ * The RMS (root mean square) ground error is available through the 
+ * appropriate getter.
  * 
  * Please note that GCPs are infered to be given in physical
  * coordinates. This is seamless in most cases.
@@ -117,11 +117,11 @@ public:
   itkGetObjectMacro(DEMHandler,DEMHandlerType);
 
   /** Get the residual ground error */
-  itkGetConstReferenceMacro(ResidualGroundError,double);
+  itkGetConstReferenceMacro(RMSGroundError,double);
   
   /** Get the GCPsContainer
    * \return The GCPs container */
-  GCPsContainerType & GetGCPsContainer() const;
+  GCPsContainerType & GetGCPsContainer();
 
   /** Set the GCP container */
   void SetGCPsContainer(const GCPsContainerType & container);
@@ -161,7 +161,7 @@ private:
   bool   m_UseImageGCPs;
 
   /** The residual ground error */
-  double m_ResidualGroundError;
+  double m_RMSGroundError;
 
   /** True if a DEM should be used */
   bool m_UseDEM;

Code/Projections/otbGCPsToRPCSensorModelImageFilter.txx

@@ -32,7 +32,7 @@ namespace otb {
 template < class TImage >
 GCPsToRPCSensorModelImageFilter<TImage>
 ::GCPsToRPCSensorModelImageFilter() : m_UseImageGCPs(true), 
-				      m_ResidualGroundError(0.), 
+				      m_RMSGroundError(0.), 
 				      m_UseDEM(false),
 				      m_MeanElevation(0.), 
 				      m_DEMHandler(),
@@ -61,7 +61,7 @@ template < class TImage >
 typename GCPsToRPCSensorModelImageFilter< TImage >
 ::GCPsContainerType &
 GCPsToRPCSensorModelImageFilter< TImage >
-::GetGCPsContainer() const
+::GetGCPsContainer()
 {
   // return the GCPs container
   return m_GCPsContainer;
@@ -197,7 +197,7 @@ GCPsToRPCSensorModelImageFilter< TImage >
   rpcSolver->solveCoefficients(sensorPoints,geoPoints);
 
   // Retrieve the residual ground error
-  m_ResidualGroundError = rpcSolver->getRmsError();
+  m_RMSGroundError = rpcSolver->getRmsError();
 
   // Retrieve the output RPC projection
   ossimRefPtr<ossimRpcModel> rpcModel = dynamic_cast<ossimRpcModel*>(rpcSolver->createRpcModel()->getProjection());
@@ -227,7 +227,7 @@ GCPsToRPCSensorModelImageFilter< TImage >
     {
     os<<indent<<"MeanElevation: "<<m_MeanElevation<<std::endl;
     }
-  os<<indent<<"Residual ground error: "<<m_ResidualGroundError<<std::endl;
+  os<<indent<<"RMS ground error: "<<m_RMSGroundError<<std::endl;
 }
 
 } // end of namespace otb

Testing/Code/Projections/otbGCPsToRPCSensorModelImageFilterWithoutDEM.cxx

@@ -78,7 +78,7 @@ int otbGCPsToRPCSensorModelImageFilterWithoutDEM( int argc, char* argv[] )
   ofs.precision(10);
 
   ofs<<rpcEstimator->GetOutput()->GetImageKeywordlist()<<std::endl;
-  ofs<<"Residual ground error: "<<rpcEstimator->GetResidualGroundError()<<std::endl;
+  ofs<<"Residual ground error: "<<rpcEstimator->GetRMSGroundError()<<std::endl;
   ofs.close();
 
   return EXIT_SUCCESS;