Merge branch 'some_warning_fixes' of...

Merge branch 'some_warning_fixes' of https://gitlab.orfeo-toolbox.org/remote_modules/diapotb into cosmo

app/otbSARFineMetadata.cxx

@@ -31,11 +31,20 @@
 #include <cmath>
 
 // include ossim
+#if defined(__GNUC__) || defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
 #include "ossim/ossimTimeUtilities.h"
 #include "ossim/base/ossimKeywordlist.h"
 #include "ossim/base/ossimString.h"
 #include "ossim/base/ossimDate.h"
-
+#pragma GCC diagnostic pop
+#else
+#include "ossim/ossimTimeUtilities.h"
+#include "ossim/base/ossimKeywordlist.h"
+#include "ossim/base/ossimString.h"
+#include "ossim/base/ossimDate.h"
+#endif
 
 namespace otb
 {

include/otbSARDEMProjectionImageFilter.txx

@@ -29,8 +29,16 @@
 #include "itkProgressReporter.h"
 #include "itkNumericTraitsPointPixel.h"
 
+#if defined(__GNUC__) || defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
 #include "ossim/base/ossimFilename.h"
 #include "ossim/base/ossimGpt.h"
+#pragma GCC diagnostic pop
+#else
+#include "ossim/base/ossimFilename.h"
+#include "ossim/base/ossimGpt.h"
+#endif
 
 #include <cmath>
 

include/otbSARDopplerCentroidFreqImageFilter.txx

@@ -90,7 +90,7 @@ namespace otb
     
     for (std::size_t listId=0; listId!= nbLists ; ++listId) 
       {
-	const int pos = sprintf(fmRatePrefix_, "%s%d.", FM_PREFIX.c_str(), (listId+1));
+	const int pos = sprintf(fmRatePrefix_, "%s%zu.", FM_PREFIX.c_str(), (listId+1));
 	assert(pos > 0 && pos < sizeof(fmRatePrefix_));
 	const std::string FMPrefix(fmRatePrefix_, pos);
 
@@ -120,7 +120,7 @@ namespace otb
     
     for (std::size_t listId=0; listId!= nbLists ; ++listId) 
       {
-	const int pos = sprintf(dcfPrefix_, "%s%d.", DCF_PREFIX.c_str(), (listId+1));
+	const int pos = sprintf(dcfPrefix_, "%s%zu.", DCF_PREFIX.c_str(), (listId+1));
 	assert(pos > 0 && pos < sizeof(dcfPrefix_));
 	const std::string DCFPrefix(dcfPrefix_, pos);
 

include/otbSARESDOffsetsImageFilter.txx

@@ -184,9 +184,6 @@ namespace otb
 	// For each colunm
 	while (!OutIt.IsAtEndOfLine() && !In1It.IsAtEndOfLine() && !In2It.IsAtEndOfLine()) 
 	  {
-	    // Output index
-	    ImageIndexType index = OutIt.GetIndex();
-
 	    double diff_DopCentroid = In1It.Get() - In2It.Get();
 
 	    // Shift for azimut dimension

include/otbTilesAnalysisImageFilter.h

@@ -190,7 +190,7 @@ protected:
       first tile */
   virtual void ThreadedGenerateData(unsigned int startTileId, unsigned int stopTileId, 
 				    unsigned int firstTileIndexL, unsigned int firstTileIndexC,
-				    itk::ThreadIdType threadId);
+				    itk::ThreadIdType threadId) ITK_OVERRIDE;
 
  /** Static function used as a "callback" by the MultiThreader.  The threading
   * library will call this routine for each thread, which will delegate the

include/otbTilesExampleFunctor.h

@@ -111,7 +111,7 @@ public:
 
   // Process
   void Process(ImageInPointer inputPtr, ImageOutRegionType outputRegion, ImageOutPixelType * TilesResult, 
-	       int threadId=0)
+	       int /*threadId=0*/)
   {
     // Transpose outputRegion (current tile) into input image
     // Input (= output now)

test/otbSARDopplerCentroidFreqImageFilterTest.cxx

@@ -39,8 +39,7 @@ int otbSARDopplerCentroidFreqFilterTest(int argc, char * argv[])
   
   // Image type
   const unsigned int Dimension = 2;
-  typedef otb::Image <std::complex<float>, 2>       ImageSARInType ;
-  typedef otb::Image <float, 2>                       FloatImageType;
+  typedef otb::Image <float, Dimension>              FloatImageType;
   typedef otb::VectorImage<float>                    FloatVectorImageType;
 
   // Reader