REFAC: include-what-you-use in Modules/Core/

Summary

Fix includes in Modules/Core.

Rationale

See issue #1635 (closed).

Implementation Details

Additional notes

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

***Check before merging:*** - All discussions are resolved - At least 2 votes from core developers, no vote. - The feature branch is (reasonably) up-to-date with the base branch - Dashboard is green - Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

+1 for not adding comment (on why included) right after #include

dashboard is green, waiting for votes

I am a bit confused: voting a MR that actually adds more #include whereas the main topic is to reduce them...

I read it as removing unnecessary includes from headers and moving them to .cxx files. I think it also adds some includes for headers that are necessary, but used to get dragged in by another header.

It probably doesn't help much, but still sounds like a good idea.

Yes @lnicola explanation is correct. It's mostly about good practice. The full output of iwyu (#1635 (closed)) did reveal some unnecessary includes but very few. Because there are so many false positives it takes a lot of effort to patch correctly. I only did it for Modules/Core.

merged

mentioned in commit 5062cd2a

added refactoring label

changed milestone to %7.0.0