Skip to content

Refactor in Modules/Wrappers/QtWidget

Victor Poughon requested to merge 1646-qt5-signal-slot into develop

Summary

Refactoring of Modules/Wrappers/QtWidget that includes:

  • Upgrade calls to QObject::connect to the statically type-checked new signal/slot syntax of Qt5 for the module Modules/Wrappers/QtWidget.
  • Remove some dead code and superfluous comments
  • Make getters and setters not inline where not necessary (clean up the code)

Rationale

Part of #1646 (closed) and #1649 (closed)

Implementation Details

Requires to change the visibility of some slots from protected to public (QtWidgetModel::ExecuteAndWriteOutputSlot and QtWidgetView::UnhandledException).

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

***Check before merging:*** - All discussions are resolved - At least 2 👍 votes from core developers, no 👎 vote. - The feature branch is (reasonably) up-to-date with the base branch - Dashboard is green - Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Edited by Victor Poughon

Merge request reports