Skip to content

Remove more c_str with SetFileName string overload

Victor Poughon requested to merge 513-SetFileName into develop

Summary

  • Make readers' and writers' SetFileName string overload the main one, and make const char* call it (instead of the over way around)
  • Remove 53 calls to c_str using:
find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/SetFileName\((.*)\.c_str\(\)/SetFileName\(\1/"

Rationale

#513 (closed), the hunt for c_str

Implementation Details

Also replace some method type signatures with const string reference instead of string by value. Also adds the missing file otbWrapperOutputVectorDataParameter.cxx and move WrapperOutputVectorDataParameter code from the .h to the .cxx.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Edited by Victor Poughon

Merge request reports