Skip to content

Update deprecated cmake policies to NEW

Manuel Grizonnet requested to merge change_cmake_policies into develop

Summary

Update cmake policies in OTB which are deprecated since cmake 3.0 and 3.1.

The branch contains also minor warnings fixes for gcc 8.1.

Let's see how it looks on the dashboard.

Rationale

cmake warnings:

https://dash.orfeo-toolbox.org/viewConfigure.php?buildid=342319

CMake Deprecation Warning at CMakeLists.txt:36 (cmake_policy):
  The OLD behavior for policy CMP0046 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.


CMake Deprecation Warning at CMakeLists.txt:42 (cmake_policy):
  The OLD behavior for policy CMP0054 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.

gcc warnings (this MR did not fix warnings related to openmpi):

https://dash.orfeo-toolbox.org/viewBuildError.php?type=1&buildid=342319

Implementation Details

Additional notes

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Edited by Manuel Grizonnet

Merge request reports