Update insource build error message

Summary

Update the error message shown in case an in-source build is attempted.

Rationale

Remove reference to mercurial scm.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

Status: needs votes

I wonder why you got rid of the example.
If you point the documentation can you add where? OTB documentation is quiet a maze...

I removed the example because I find it more confusing than helpful. To me an error message should give you information on what is wrong but not be a tutorial. Just my opinion of course. Yes the doc is quite a maze... Right now the official build instructions are the software guide I think: https://www.orfeo-toolbox.org/SoftwareGuide/SoftwareGuidech2.html#x16-190002 and the example in the previous error message used a different convention than the docs. And this might change in the future is we rewrite this section or move it to the cookbook, so in general I think a simple and explicit error message is better here, just to be sure not to give wrong information. I can add "see the software guide" maybe?

Yes!
Adding "see the software guide section 2.2.1" seems good to me!

added 1 commit

• 25b77a9f - DOC: improve PreventInSourceBuilds error message

Compare with previous version

done!

status: needs votes

mentioned in commit 525b8691

merged

added refactoring label

changed milestone to %7.0.0