Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 207
    • Issues 207
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !404

Fix bug in extract roi

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Antoine Regimbeau requested to merge extractroi_modefit into develop Mar 05, 2019
  • Overview 16
  • Commits 11
  • Pipelines 6
  • Changes 1

Summary

This MR aims at fixing #1815 (closed) and also improves log and behavior of the ExtractROI application.

Rationale

ExtractROI is a very simple application it should flawless.

Implementation Details

Here are some bugs fixed:

  • Bug from #1815 (closed) is fixed
  • Bug in the radius mode: we should extract as if the center and radius gives us an extent
  • Log
Tests

Test will be done in an other MR. No test has been added here.

Additional notes

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Edited May 16, 2019 by Antoine Regimbeau
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: extractroi_modefit