Clean-up of unused or low quality modules and filters

Summary

Closes #1763 (closed) Closes #1765 (closed)

This MR delete the following Modules: DisplacementField, RCC8, UrbanArea, RoadExtraction, ObjectDetection, MorphologicalPyramid, SeamCarving

It also removes the Dempster-Shafer based classification of vectors framework, an orphaned class for GIS connexion and the OrthoRectificationFilter.

Each removal is made in a separate commit, so that it will be easier to revert if needed.

Rationale

Those modules and code have been removed because they are not really used or useful. In #1765 (closed) I suggested to move code to remote modules, but this does not make any sense: if we are not maintaining them, they will break at some point. If someone need them, they are up and working until OTB 6.6.1.

The overall goal is to make OTB lighter to build, test and package. Less classes also means a clearer API for users.

Here is the rationale for each change:

• RCC8 and MorphologicalPyramid is the code for the following paper. It does not perform well enough for any practical application.
• DisplacementField was merely a proof of concept. It has no real practical application.
• RoadExtractionis the code for the following paper. It does not perform well enough for any practical application.
• UrbanArea: Module designed back before Pleiades launch. It does not perform well enough for any practical application.
• ObjectDetection is the code for the following paper. It does not perform well enough for any practical application (and today the state of the art for object detection is using deep learning)
• SeamCarving is an implementation of the following paper. To my best knowledge, there is no application to this algorithm in remote sensing field.
• Dempster-Shafer based classification of vectors framework is an implementation of the following phd work. It does not perform well enough for any practical application.
• The GIS connexion class was orphan. If we were to connect to a GIS database, we would rely on Gdal backend.
• The OrthoRectificationFilter was deriving from GenericRSResampleImageFilter without adding any additional feature. The latter is now used throughout OTB.

Implementation Details

All classes, CMake Files, examples, baselines and input data have been removed.

Additional notes

There are a few more modules that we may want to remove:

• LandSatClassifier: @jinglada suggested to remove it, but I am not sure.

Any other suggestions ?

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 👍 votes from core developers, no 👎 vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

changed milestone to %7.0.0

There's a few things still making reference to the removed things:

~/cnes/dev/otb (cleanup|✔) $ ag "RCC8|MorphologicalPyramid|RoadExtraction|UrbanArea|ObjectDetection|SeamCarving|OrthoRectificationFilter"
Documentation/Cookbook/rst/CompilingOTBFromSource.rst
328:| **OTB\_USE\_MUPARSER**    | OTBMuParser            | OTBMathParser OTBDempsterShafer OTBAppClassification OTBAppMathParser OTBAppStereo OTBAppProjection OTBAppSegmentation OTBRoadExtraction OTBRCC8 OTBCCOBIA OTBMeanShift   |

Modules/Registration/Stereo/test/otbMulti3DMapToDEMFilter.cxx
159:  typedef otb::OrthoRectificationFilter<VectorImageType, VectorImageType, UtmMapProjectionType> OrthoRectifFilterType;
234:  typedef otb::OrthoRectificationFilter<VectorImageType, VectorImageType, UtmMapProjectionType> OrthoRectifFilterType;
413:typedef otb::OrthoRectificationFilter<VectorImageType, VectorImageType, UtmMapProjectionType> OrthoRectifFilterType;

Modules/Feature/Edge/test/CMakeLists.txt
123:  ${INPUTDATA}/Seg1InputForRCC8Graph.tif

Modules/Segmentation/MorphologicalProfiles/include/otbClosingOpeningMorphologicalFilter.h
43: * MorphologicalPyramidAnalysisFilter

Modules/Segmentation/MorphologicalProfiles/include/otbOpeningClosingMorphologicalFilter.h
43: * MorphologicalPyramidAnalyseFilter

Modules/Segmentation/Metrics/test/CMakeLists.txt
50:  ${INPUTDATA}/Seg1InputForRCC8Graph.tif
51:  ${INPUTDATA}/Seg2InputForRCC8Graph.tif

Modules/Filtering/ImageManipulation/include/otbBinaryImageMinimalBoundingRegionCalculator.h
34: * This class is used for instance in the RCC8 calculator filter,
39: * \sa ImageToImageRCC8Calculator

and a lot of "DisplacementField" (too many to show here).

changed title from WIP: Clean-up of unused or cheesy modules and filters to WIP: Clean-up of unused or low quality modules and filters

changed the description

unmarked as a Work In Progress

added 8 commits

• ada56381 - STY: Remove commented code refering to removed class
• d1427194 - DOC: Update doxygen refering to removed classes
• 22d90a5b - TEST: Update tests to avoid using removed input image
• f2f0d83d - REFAC: Remove class that is unused in OTB following removal of RCC8 module
• da4613ad - REFAC: Remove class that is unused in OTB following removal of RCC8 module
• 924c4376 - TEST: Fix tests depending on removed files rcc8_mire*
• 409a68ca - REFAC: Remove otb::VectorizationPathListFilter which was part of the road extraction framework
• ed7045a3 - TEST: Replace removed input in test

Compare with previous version

changed the description

@poughov thanks I fixed all of them. References to DisplacementField are still valid since (it is still something that we use in OTB).

added 54 commits

• ed7045a3...caad42d6 - 52 commits from branch develop
• 37513e73 - Merge branch 'develop' into cleanup
• e5524e4d - TEST: Fix failing tests following input changes

Compare with previous version

added 1 commit

• 7631d444 - DOC: Remove references to removed examples in documentation

Compare with previous version

added refactoring label

Status: Needs votes. Dashboard is green.

edit: no I broke something while trying to fix the merge conflict. I am investigating.

added 47 commits

• 7631d444...eb92becf - 46 commits from branch develop
• 513bc39d - Merge branch 'develop' into cleanup

Compare with previous version

added 1 commit

• a9c2498d - BUG: fix missing file after merge conflict

Compare with previous version

I fixed the merge with develop today, so I will merge on monday if dashboard comes green.

mentioned in commit f7127e4b

merged

merged. documented in #1682 (closed)

mentioned in issue #1682 (closed)