Skip to content
Snippets Groups Projects

Resolve "pipeline containing a BandMath failed"

Merged Victor Poughon requested to merge 1899-input-param-bug into develop
All threads resolved!

Summary

  • Add missing checks on existing m_Image and m_OutputCaster
  • Add C++ and python test

Rationale

Closes #1899 (closed)

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

Merge request reports

Pipeline #1592 passed

Pipeline passed for fbbbc458 on 1899-input-param-bug

Merged by Victor PoughonVictor Poughon 5 years ago (May 28, 2019 7:21am UTC)

Merge details

Pipeline #1604 failed

Pipeline failed for 0ebe000d on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Victor Poughon added 5 commits

    added 5 commits

    • 9b72708f - BUG: clarify GetImage() error message
    • f07c7ead - BUG: InputImageParameter check for existing output caster
    • 02d5293a - BUG: add more tests cases for InputImageParameter::GetImage()
    • 608d3764 - STYLE: clang-format
    • fbbbc458 - WRG: remove unused parameter name

    Compare with previous version

  • Victor Poughon mentioned in issue #1909

    mentioned in issue #1909

  • Author Contributor

    ok I have pushed a few commits that:

    • Add a check for an existing caster, and raise an exception
    • Improve the error message in case of multiple calls with different types
    • Add 3 tests for GetImage to test the various code paths (image/filename, same/different types)

    And I also opened issue #1909 to begin work on a further refactor of GetImage that does beyond fixing the original bug of this MR (#1899 (closed))

    Edited by Victor Poughon
  • Victor Poughon resolved all discussions

    resolved all discussions

  • Victor Poughon mentioned in commit 0ebe000d

    mentioned in commit 0ebe000d

  • Please register or sign in to reply
    Loading