Skip to content
Snippets Groups Projects

Resolve "Mention CCLA and ICLA in Contribute.md"

Merged Resolve "Mention CCLA and ICLA in Contribute.md"
1552-contribute-md-does-not-mention-ccla-and-icla into develop
All threads resolved!
Merged Manuel Grizonnet requested to merge 1552-contribute-md-does-not-mention-ccla-and-icla into develop
All threads resolved!

Closes #1552 (closed)

Edited by Manuel Grizonnet

Merge request reports

Approval is optional

Merged by Manuel GrizonnetManuel Grizonnet 7 years ago (Apr 18, 2018 1:28pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Julien Michel
  • Julien Michel
    Julien Michel @jmichel
    Reporter

    Issue stalled. Can we go on with the discussion ?

  • Julien Michel added documentation label

    added documentation label

  • Manuel Grizonnet added 1 commit

    added 1 commit

    • de6ef391 - ENH: take into account reviewers comments and add statement about copyright…

    Compare with previous version

  • Manuel Grizonnet added 114 commits

    added 114 commits

    • de6ef391...cc1d161c - 113 commits from branch develop
    • ed47e3a2 - Merge branch 'develop' into 1552-contribute-md-does-not-mention-ccla-and-icla

    Compare with previous version

  • Manuel Grizonnet added patch label

    added patch label

  • Manuel Grizonnet changed milestone to %6.6.0

    changed milestone to %6.6.0

  • Manuel Grizonnet assigned to @mgrizonnet

    assigned to @mgrizonnet

  • Manuel Grizonnet resolved all discussions

    resolved all discussions

  • Manuel Grizonnet unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Manuel Grizonnet
    Manuel Grizonnet @mgrizonnet
    Author Developer

    @sdinot Can you please review this MR and tell if you think it is OK? Thanks

  • Julien Michel resolved all discussions

    resolved all discussions

  • Julien Michel added 1 commit

    added 1 commit

    Compare with previous version

  • Sébastien Dinot
    Sébastien Dinot @sdinot
    Owner

    @mgrizonnet I reviewed your merge request. Nothing to add, it's good for me.

  • Manuel Grizonnet mentioned in commit f11f9bcd

    mentioned in commit f11f9bcd

  • Manuel Grizonnet merged

    merged

  • Manuel Grizonnet
    Manuel Grizonnet @mgrizonnet
    Author Developer

    Thanks @sdinot ! It is merged now in develop.

    • Please register or sign in to reply