Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 189
    • Issues 189
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !544

Cmake 3.10.2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Antoine Regimbeau requested to merge cmake_upgrade into develop Jul 10, 2019
  • Overview 11
  • Commits 37
  • Pipelines 10
  • Changes 46

Summary

This MR upgrade CMake to 3.10.2. This version of CMake si the one packaged for Ubuntu 18.04. It is linked to #1905 (closed), and #528 (closed) (Compatibility with ITK5).

Rationale

The main work here was to look at some improvement that could be done on the CMake code. Lots of comments have been made, some modifications at iso-functionalities and some deletion (unused code, commented code).
This MR is the introduction of a bigger work: the CMake code cleaning.

Additional notes

See #1940 (closed) for more detail of what has been investigated in here.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited Jul 11, 2019 by Antoine Regimbeau
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: cmake_upgrade