Skip to content

GitLab

CI: Use clang for ubuntu superbuild

Closed Cédric Traizet requested to merge ci_clang_superbuild into develop

Summary

Use clang when compiling xdk on ubuntu CI jobs.

Rationale

In CI ubuntu jobs, the Superbuild xdk is currently compiled with gcc while otb is compiled with clang.

In particular, this means that ITK is compiled with gcc whereas otb is compiled with clang. This is not a problem if we want to compile otb using ITK4: ITK uses the cmake WriteCompilerDetectionHeader function, which produces headers defining the allowed compilers when including ITK files. In ITK4 the list of allowed compilers is fixed (AppleClang Clang GNU MSVC SunPro and Intel) but in ITK5 the only compiler allowed is the one used to compile ITK.

Therefore we should use the same compiler for ITK and OTB

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited by Cédric Traizet