Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 184
    • Issues 184
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !750

WRN: Fix field construction order

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Luc Hermitte requested to merge lhermitte/otb:FixWRNFieldsOrder into develop Sep 14, 2020
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 2

Summary

Suppress a warning emitted by g++.

Rationale

Field declaration order and field construction order should match as ambiguity may arise: it's always the field declarations order that matter. The other one is ignored.

This commit is meant to silence gcc -Wreorder warning we can see in https://cdash.orfeo-toolbox.org/viewBuildError.php?type=1&buildid=52525

../Modules/Filtering/ImageManipulation/include/otbGridResampleImageFilter.hxx:44:5: warning: field 'm_CheckOutputBounds' will be initialized after field 'm_InterpolationMargin' [-Wreorder]

Implementation Details

I've taken advantage of C++11 member initialization to lift the ordering burden.

Copyright

The copyright owner is COPYRIGHT OWNER (OR OWNER'S AGENT) and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: FixWRNFieldsOrder