WRN: Fix field construction order (!750) · Merge Requests · Main Repositories / otb

WRN: Fix field construction order

Summary

Suppress a warning emitted by g++.

Rationale

Field declaration order and field construction order should match as ambiguity may arise: it's always the field declarations order that matter. The other one is ignored.

This commit is meant to silence gcc -Wreorder warning we can see in https://cdash.orfeo-toolbox.org/viewBuildError.php?type=1&buildid=52525

../Modules/Filtering/ImageManipulation/include/otbGridResampleImageFilter.hxx:44:5: warning: field 'm_CheckOutputBounds' will be initialized after field 'm_InterpolationMargin' [-Wreorder]

Implementation Details

I've taken advantage of C++11 member initialization to lift the ordering burden.

Copyright

The copyright owner is COPYRIGHT OWNER (OR OWNER'S AGENT) and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

All discussions are resolved
At least 2 👍 votes from core developers, no 👎 vote.
The feature branch is (reasonably) up-to-date with the base branch
Dashboard is green
Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

#### Summary

Suppress a warning emitted by g++.

#### Rationale

Field declaration order and field construction order should match as ambiguity
may arise: it's always the field declarations order that matter. The other one
is ignored.

This commit is meant to silence gcc `-Wreorder` warning we can see in https://cdash.orfeo-toolbox.org/viewBuildError.php?type=1&buildid=52525

```
../Modules/Filtering/ImageManipulation/include/otbGridResampleImageFilter.hxx:44:5: warning: field 'm_CheckOutputBounds' will be initialized after field 'm_InterpolationMargin' [-Wreorder]

```

#### Implementation Details

I've taken advantage of C++11 [member initialization](https://en.cppreference.com/w/cpp/language/data_members#Member_initialization) to lift the ordering burden.

#### Copyright

The copyright owner is *COPYRIGHT OWNER (OR OWNER'S AGENT)* and has signed the ORFEO ToolBox Contributor License Agreement.

<hr>

***Check before merging:***

- All discussions are resolved
- At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
- The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit

Check out, review, and merge locally