Skip to content

Improve tests prTvTestCreateInverseForwardSensorModel

Julien Osman requested to merge improve_tests_InverseForwardSensorModel into develop

Summary

Improve the tests prTvTestCreateInverseForwardSensorModel_Toulouse and prTvTestCreateInverseForwardSensorModel_Cevennes so it compares return values.

Rationale

The tests for the otb::SensorModel classes were removed years ago, because the they depended on the precision in OSSIM, that could change with OSSIM's version. This was fine at this time, because the values were validated in OSSIM, and the OTB part was tested in the filters. But we are introducing big changes with the remove OSSIM story, and tests closer to the changes are helpful to track down eventual regressions. We set a big tolerance on the values, so little changes of prevision in the dependencies wont affect this tests.

Implementation Details

Tests

Add the possibility to set an optional DEM. Add an inverse transform and a forward transform of a point in the image, to assert the quality of the transformation.

Additional notes

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited by Julien Osman

Merge request reports