Skip to content

COMP: Catch bad_any_cast by reference, not value

Laurențiu Nicola requested to merge bad-any-cast into develop

Summary

Catch the exception by reference, not value.

Rationale

Exceptions caught by value are sliced, and this silences a warning.

Additional notes

Split off !786 (merged). Sorry for the tiny PRs, but it's hard for me to understand the CI error from there.

Copyright

The copyright owner is Laurențiu Nicola (CS ROMANIA) and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited by Laurențiu Nicola

Merge request reports