Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 210
    • Issues 210
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !831

Fix thermal noise removal in Sentinel 1 calibration

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Cédric Traizet requested to merge noise_s1_test into release-7.4 Jul 22, 2021
  • Overview 4
  • Commits 8
  • Pipelines 8
  • Changes 12

Summary

This merge request fix two issues in the thermal noise:

  • For VH products, the VV LUTs were read by ossimplugins instead of the VH LUTs (calibration LUT and noise), resulting in error in the denoising. For the calibration, it seems that the LUT are identical for VV and VH products (is it always the case?).
  • There was a cast from double to int, causing small errors in the computed noise.

The results have been validated by hand for a few points, and on a whole product by comparing the output produced by the SARCalibration application with the calibration produced by snap. Some differences have been noticed between the outputs of the two software, but there are likely caused by a bug in SNAP

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited Jul 29, 2021 by Cédric Traizet
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: noise_s1_test