Add missing include and fix compilation on windows
In otbSARDerampImageFilter
there is a missing include (otbVectorImageFilter
) which causes otb CI to fail.
Also the master version of diapOTB doesn't compile on windows (MSVC) because of a C-array with a length defined at run time, which is non standard in C++, even it is allowed by gcc.
This MR adds fixes for these two issues.
See also these otb CI pipelines:
- with the master branch of diapotb : https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/pipelines/2687
- with the fixes : https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/pipelines/2691
Merge request reports
Activity
@ussegliog waiting for your review to merge
also I don't think
SARTemporalCorrelationGridFilter
is tested (or theSARCorrelationGrid
application`)mentioned in merge request orfeotoolbox/otb!597 (merged)
Ok to merge. Thanks for corrections.
About the tests on deformation grid application/filter (like
SARTemporalCorrelationGridFilter
), I need to compare two SAR images lightly shifted and also small to store its into Gitlab.Without the meaningful data, I cannot include this kind of filters into ctest.
mentioned in commit ec597075